Skip to content

feat(core): support TypeScript 4.5#44164

Closed
crisbeto wants to merge 1 commit intoangular:masterfrom
crisbeto:ts-4.5
Closed

feat(core): support TypeScript 4.5#44164
crisbeto wants to merge 1 commit intoangular:masterfrom
crisbeto:ts-4.5

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Nov 13, 2021 •
edited
Loading

Adds support for TypeScript 4.5. Includes the following changes:

  • Bumping the package versions.
  • Fixing a few calls to createExportSpecifier and createImportSpecifier that require an extra parameter.
  • Adding some missing methods to the TS compiler hosts.
  • Fixing an issue in the TS mocks for the ngcc tests where a regex was too agressive and was trying to match a path like /node_modules/@typescript/lib-es5.
  • Accounting for type-only import specifiers when reporting DI errors (see Account for type-only import specifier in TS 4.5 #43620).

Fixes #43620.

@google-cla google-cla Bot added the cla: yes label Nov 13, 2021
@crisbeto crisbeto mentioned this pull request Nov 14, 2021
Closed
@crisbeto crisbeto force-pushed the ts-4.5 branch 8 times, most recently from 4e774c7 to 926ea7c Compare November 15, 2021 14:35
JoostK
JoostK reviewed Nov 16, 2021
View reviewed changes
Comment thread packages/compiler-cli/src/ngtsc/transform/src/alias.ts Outdated
Comment thread packages/core/schematics/utils/import_manager.ts Outdated
@AndrewKushnir AndrewKushnir added the area: core Issues related to the framework runtime label Nov 18, 2021
@ngbot ngbot Bot added this to the Backlog milestone Nov 18, 2021
@alan-agius4 alan-agius4 mentioned this pull request Nov 22, 2021
Closed
15 tasks
@crisbeto crisbeto marked this pull request as ready for review November 23, 2021 10:33
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Nov 23, 2021
IgorMinar
IgorMinar approved these changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Reviewed-for: global-approvers

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Nov 24, 2021
@crisbeto crisbeto added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 29, 2021
@crisbeto crisbeto force-pushed the ts-4.5 branch 2 times, most recently from ef8689b to 95b6367 Compare November 30, 2021 10:25
@crisbeto
feat(core): support TypeScript 4.5
51eb3e9 
Adds support for TypeScript 4.5. Includes the following changes:
* Bumping the package versions.
* Fixing a few calls to `createExportSpecifier` and `createImportSpecifier` that require an extra parameter.
* Adding some missing methods to the TS compiler hosts.
* Fixing an issue in the TS mocks for the ngcc tests where a regex was too agressive and was trying to match a path like `/node_modules/@typescript/lib-es5`.
* Accounting for type-only import specifiers when reporting DI errors (see angular#43620).

Fixes angular#43620.
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Nov 30, 2021

I pushed some more code in order to make the changes easier to sync into g3. The tl;dr is that I had to add a few temporary as any casts that I'll clean up later.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 30, 2021
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Nov 30, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    failure status "ci/circleci: test_win" is failing
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Nov 30, 2021

Merge assistance: the PR was reviewed already, but PullApprove is broken.

@IvayloG IvayloG mentioned this pull request Nov 30, 2021
Closed
@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented Nov 30, 2021

This PR was merged into the repository by commit d56e3f4.

@dylhunn dylhunn closed this in d56e3f4 Nov 30, 2021
@gkalpak gkalpak mentioned this pull request Dec 2, 2021
Closed
1 task
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Dec 31, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

+1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Account for type-only import specifier in TS 4.5

5 participants

@crisbeto @dylhunn @JoostK @IgorMinar @AndrewKushnir