fix(compiler-cli): do not error with prepocessing if component has no inline styles#41602
Closed
clydin wants to merge 1 commit intoangular:masterfrom
Closed
fix(compiler-cli): do not error with prepocessing if component has no inline styles#41602clydin wants to merge 1 commit intoangular:masterfrom
clydin wants to merge 1 commit intoangular:masterfrom
Conversation
clydin
added
type: bug/fix
action: review
clydin
added
the
area: compiler
… inline styles The asynchronous preprocessing check was not accounting for components that did not have any inline styles. In that case, the cache did not have an entry which then allowed the asynchronous check to run and fail the compilation. The caching during the asynchronous analysis phase now handles components without inline styles.
clydin
force-pushed
the
transform-resources
branch
from
8f22f0c to
fa4356c
Compare
JoostK
approved these changes
Apr 13, 2021
clydin
removed
the
action: review
AndrewKushnir
added
the
action: presubmit
Contributor
AndrewKushnir
removed
the
action: presubmit
zarend
pushed a commit
that referenced
this pull request
Apr 14, 2021
… inline styles (#41602) The asynchronous preprocessing check was not accounting for components that did not have any inline styles. In that case, the cache did not have an entry which then allowed the asynchronous check to run and fail the compilation. The caching during the asynchronous analysis phase now handles components without inline styles. PR Close #41602
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The asynchronous preprocessing check was not accounting for components that did not have any inline styles. In that case, the cache did not have an entry which then allowed the asynchronous check to run and fail the compilation. The caching during the asynchronous analysis phase now handles components without inline styles.