refactor(language-service): stop tracking lastKnownProgram in CompilerFactory#41517
Closed
kyliau wants to merge 1 commit intoangular:masterfrom
Closed
refactor(language-service): stop tracking lastKnownProgram in CompilerFactory#41517kyliau wants to merge 1 commit intoangular:masterfrom
lastKnownProgram in CompilerFactory#41517kyliau wants to merge 1 commit intoangular:masterfrom
Conversation
…rFactory With the work done in angular#41291, the compiler always tracks the last known program, so there's no need to track the program in the compiler factory anymore.
kyliau
added
area: language-service
kyliau
added
target: major
atscott
approved these changes
Apr 8, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the work done in #41291, the compiler always tracks the last known
program, so there's no need to track the program in the compiler factory
anymore.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information