fix(compiler-cli): allow relative rootDir#41359
Closed
literalpie wants to merge 2 commits intoangular:masterfrom
Closed
fix(compiler-cli): allow relative rootDir#41359literalpie wants to merge 2 commits intoangular:masterfrom
literalpie wants to merge 2 commits intoangular:masterfrom
Conversation
5 tasks
literalpie
force-pushed
the
relative-root-dir
branch
4 times, most recently
from
4bf7f49 to
851ea1e
Compare
AndrewKushnir
requested review from
JoostK and
petebacondarwin
and removed request for
AndrewKushnir
petebacondarwin
approved these changes
Mar 30, 2021
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Great! Thanks @literalpie - I think this unit test is enough.
Can you modify the commit message? It doesn't need to mention the previous PR particularly, IMO. Perhaps:
fix(compiler-cli): resolve `rootDirs` to absolute paths
Ensure that `rootDirs` are absolute by resolving them against the
current working directory.
Fixes #36290
petebacondarwin
added
action: review
literalpie
force-pushed
the
relative-root-dir
branch
from
851ea1e to
d74a830
Compare
Contributor
Author
|
@petebacondarwin done! |
Contributor
|
Thanks for picking this up @literalpie! |
literalpie
force-pushed
the
relative-root-dir
branch
from
d74a830 to
b5734f2
Compare
Ensure that `rootDirs` are absolute by resolving them against the current working directory. Fixes angular#36290
literalpie
force-pushed
the
relative-root-dir
branch
from
b5734f2 to
68840e2
Compare
Member
|
I once prepped an example of how this could be testing in an "integration-like" test in JoostK@c08c753, as without such a test this is easy to regress in. @literalpie could you have a look at adding a test like that? |
JoostK
approved these changes
Apr 11, 2021
JoostK
added
action: cleanup
literalpie
force-pushed
the
relative-root-dir
branch
from
96b7dcc to
ba9f1d4
Compare
Member
|
@literalpie CI is not yet happy with the second commit; it wants it to have a short body. |
this will make it easier to detect regressions of the relative rootDir behavior
literalpie
force-pushed
the
relative-root-dir
branch
from
ba9f1d4 to
32cb493
Compare
Contributor
Author
|
@JoostK i think it's better now. Thanks for your help and for your patience |
JoostK
added
action: merge
Contributor
AndrewKushnir
removed
the
action: presubmit
zarend
added
target: minor
zarend
pushed a commit
that referenced
this pull request
Apr 12, 2021
this will make it easier to detect regressions of the relative rootDir behavior PR Close #41359
Member
|
@literalpie Thanks again for your contribution!! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #36290
What is the new behavior?
If a relative rootDir is passed in, an error is no longer thrown
Does this PR introduce a breaking change?
Other information
Building off of #36291 by @Toxicable with test added and other recommended changes.