fix(compiler): include used components during JIT compilation of partial component declaration#41353
Closed
JoostK wants to merge 1 commit intoangular:masterfrom
Closed
fix(compiler): include used components during JIT compilation of partial component declaration#41353JoostK wants to merge 1 commit intoangular:masterfrom
JoostK wants to merge 1 commit intoangular:masterfrom
Conversation
JoostK
added
target: major
JoostK
added
the
action: review
JoostK
force-pushed
the
linker/fix-jit-components
branch
from
d0c8669 to
10fa200
Compare
petebacondarwin
approved these changes
Mar 31, 2021
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM - other than the conflict.
…ial component declaration In angular#41104 the list of used directives was split into two arrays of used directives and components, but the JIT side was not updated. This commit fixes the JIT integration by including the list of used components. Fixes angular#41318
JoostK
force-pushed
the
linker/fix-jit-components
branch
from
10fa200 to
2909f3f
Compare
atscott
approved these changes
Mar 31, 2021
Contributor
JoostK
added
action: merge
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Apr 5, 2021
…ial component declaration (angular#41353) In angular#41104 the list of used directives was split into two arrays of used directives and components, but the JIT side was not updated. This commit fixes the JIT integration by including the list of used components. Fixes angular#41318 PR Close angular#41353
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #41104 the list of used directives was split into two arrays of used
directives and components, but the JIT side was not updated. This commit
fixes the JIT integration by including the list of used components.
Fixes #41318
This is only targeting major as partial declarations are not supported in v11.