Perf in logs by zarend · Pull Request #41319 · angular/angular

zarend · 2021-03-22T21:21:18Z

feat(language-service): add perf tracing to LanguageService

Adds perf tracing for the public methods in LanguageService. If the log level is verbose or higher,
trace performance results to the tsServer logger. This logger is implemented on the extension side
in angular/vscode-ng-language-service.

how to view perf tracing in vscode.

set angular log level to verbose
Run vscode action: "Open Angular Server Log"
Search for lines matching LanguageService#

grepping for log files

while testing, I saved the patch to the angular server log to an environment variable and use grep to search for perf tracing.

# grep --text LanguageService# $NG_SERVER_LOG

Test plan

This PR was tested manually against a local build of the vscode extension. I made sure that perf tracing showed up for each public method in LanguageService

google-cla · 2021-03-22T21:21:26Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-24T18:22:24Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

zarend · 2021-03-24T22:53:13Z

packages/language-service/ivy/language_service.ts

+
+    const logger = this.project.projectService.logger;
+    if (logger.hasLevel(ts.server.LogLevel.verbose)) {
+      logger.perftrc(


Note to reviewers: this is where we do the perf tracing.

packages/language-service/ivy/language_service.ts

alxhub · 2021-03-24T23:19:45Z

packages/language-service/ivy/language_service.ts

+   * @param p callback to be run synchronously with an instance of the `NgCompiler` as argument
+   * @return the result of running the `p` callback
+   */
+  private withCompilerAndPerfTracing<T>(callerName: string, p: (compiler: NgCompiler) => T): T {


Part of perf tracing is recording the time it takes each actual Language Service operation to take place. So in addition to appending the results, this function should actually execute p in a perf phase associated with the operation in question. Maybe consider taking that PerfPhase instead of callerName, and using the phase name for the logger.

I agree, it's make more sense to leverage the existing api of the perf recorder. I'll fix this.

atscott

LGTM if you add tests / explain why you can't add tests to this PR

zarend · 2021-03-29T22:14:18Z

@alxhub @atscott , I've made fixes to this PR, and it's ready for your eyes again 👀

Here's the changes since you last reviewed

added a unit test
log perf phases instead of LanguageService method names

alxhub · 2021-03-30T23:38:35Z

packages/language-service/ivy/language_service.ts

I don't think this is particularly useful to include, we can drop it.

sure, I don't feel strongly about logging this 👍

Adds perf tracing for the public methods in LanguageService. If the log level is verbose or higher, trace performance results to the tsServer logger. This logger is implemented on the extension side in angular/vscode-ng-language-service.

zarend · 2021-03-31T00:53:28Z

presubmit cl

…41319) Adds perf tracing for the public methods in LanguageService. If the log level is verbose or higher, trace performance results to the tsServer logger. This logger is implemented on the extension side in angular/vscode-ng-language-service. PR Close angular#41319

angular-automatic-lock-bot · 2021-05-01T16:06:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

zarend requested review from alxhub and atscott March 22, 2021 21:21

google-cla bot added the cla: no label Mar 22, 2021

pullapprove bot requested a review from josephperrott March 22, 2021 21:21

zarend added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service labels Mar 22, 2021

ngbot bot added this to the Backlog milestone Mar 22, 2021

zarend force-pushed the perf-in-logs branch from dd9e389 to 79b375b Compare March 24, 2021 18:22

zarend force-pushed the perf-in-logs branch from 79b375b to 03c4b75 Compare March 24, 2021 22:45

google-cla bot added cla: yes and removed cla: no labels Mar 24, 2021

zarend commented Mar 24, 2021

View reviewed changes

alxhub reviewed Mar 24, 2021

View reviewed changes

packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved

alxhub requested changes Mar 24, 2021

View reviewed changes

atscott approved these changes Mar 24, 2021

View reviewed changes

zarend added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 25, 2021

zarend force-pushed the perf-in-logs branch from 03c4b75 to 4360ae5 Compare March 29, 2021 22:11

zarend force-pushed the perf-in-logs branch from 4360ae5 to 977b9b0 Compare March 29, 2021 22:17

zarend requested review from alxhub and atscott March 29, 2021 22:18

zarend added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 29, 2021

josephperrott removed their request for review March 30, 2021 18:34

alxhub reviewed Mar 30, 2021

View reviewed changes

alxhub approved these changes Mar 30, 2021

View reviewed changes

zarend force-pushed the perf-in-logs branch from 977b9b0 to cc73af4 Compare March 30, 2021 23:43

zarend added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 31, 2021

zarend added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 31, 2021

zarend removed the request for review from atscott March 31, 2021 14:58

alxhub added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 31, 2021

alxhub closed this in 90f85da Mar 31, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perf in logs#41319

Perf in logs#41319
zarend wants to merge 1 commit intoangular:masterfrom
zarend:perf-in-logs

zarend commented Mar 22, 2021 •

edited

Loading

Uh oh!

google-cla bot commented Mar 22, 2021

Uh oh!

google-cla bot commented Mar 24, 2021

Uh oh!

zarend Mar 24, 2021

Uh oh!

Uh oh!

alxhub Mar 24, 2021

Uh oh!

zarend Mar 25, 2021

Uh oh!

atscott left a comment

Uh oh!

zarend commented Mar 29, 2021

Uh oh!

alxhub Mar 30, 2021

Uh oh!

zarend Mar 30, 2021

Uh oh!

zarend commented Mar 31, 2021

Uh oh!

angular-automatic-lock-bot bot commented May 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zarend commented Mar 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat(language-service): add perf tracing to LanguageService

how to view perf tracing in vscode.

grepping for log files

Test plan

Uh oh!

google-cla bot commented Mar 22, 2021

Uh oh!

google-cla bot commented Mar 24, 2021

Uh oh!

zarend Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alxhub Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

zarend Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

zarend commented Mar 29, 2021

Uh oh!

alxhub Mar 30, 2021

Choose a reason for hiding this comment

Uh oh!

zarend Mar 30, 2021

Choose a reason for hiding this comment

Uh oh!

zarend commented Mar 31, 2021

Uh oh!

angular-automatic-lock-bot bot commented May 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zarend commented Mar 22, 2021 •

edited

Loading