refactor(compiler-cli): specify whether a used directive is a component in partial component declaration#41104
Closed
JoostK wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
JoostK
added
action: review
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Here's a crazy idea... Instead of marking each component with isComponent, how about we change the declaration to have two properties directives and components, which get consolidated back together in the linker?
JoostK
added
action: cleanup
… in partial declaration The partial declaration of a component includes the list of directives that are used in its template, including some metadata of the directive which can be used during actual compilation of the component. Used components are currently part of this list, as components are also directives. This commit splits the used components into a dedicate property in the partial declaration, which allows for template compilation to optimize the generated code for components.
JoostK
force-pushed
the
linker/used-directives-is-component
branch
from
ff307dc to
82f0bd6
Compare
JoostK
added
action: review
petebacondarwin
approved these changes
Mar 16, 2021
Comment on lines
+77
to
+105
| const collectUsedDirectives = | ||
| (directives: AstValue<R3DeclareUsedDirectiveMetadata, TExpression>[]) => { | ||
| return directives.map(directive => { | ||
| const directiveExpr = directive.getObject(); | ||
| const type = directiveExpr.getValue('type'); | ||
| const selector = directiveExpr.getString('selector'); | ||
|
|
||
| let typeExpr = type.getOpaque(); | ||
| const forwardRefType = extractForwardRef(type); | ||
| if (forwardRefType !== null) { | ||
| typeExpr = forwardRefType; | ||
| declarationListEmitMode = DeclarationListEmitMode.Closure; | ||
| } | ||
|
|
||
| return { | ||
| type: typeExpr, | ||
| selector: selector, | ||
| inputs: directiveExpr.has('inputs') ? | ||
| directiveExpr.getArray('inputs').map(input => input.getString()) : | ||
| [], | ||
| outputs: directiveExpr.has('outputs') ? | ||
| directiveExpr.getArray('outputs').map(input => input.getString()) : | ||
| [], | ||
| exportAs: directiveExpr.has('exportAs') ? | ||
| directiveExpr.getArray('exportAs').map(exportAs => exportAs.getString()) : | ||
| null, | ||
| }; | ||
| }); | ||
| }; |
Contributor
There was a problem hiding this comment.
Ugh! I'd love to pull this out into a separate utility function at the bottom of this file.
I tried to do it myself when I originally wrote this block of code.
But the update to declarationListEmitMode makes it awkward to be in a separate function.
😞
Member
Author
There was a problem hiding this comment.
Yep, declarationListEmitMode made this into a local closure.
JoostK
added
action: rerun CI at HEAD
and removed
action: review
JoostK
added
action: merge
Contributor
AndrewKushnir
removed
the
action: presubmit
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Mar 31, 2021
…ial component declaration In angular#41104 the list of used directives was split into two arrays of used directives and components, but the JIT side was not updated. This commit fixes the JIT integration by including the list of used components. Fixes angular#41318
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Apr 5, 2021
…ial component declaration (angular#41353) In angular#41104 the list of used directives was split into two arrays of used directives and components, but the JIT side was not updated. This commit fixes the JIT integration by including the list of used components. Fixes angular#41318 PR Close angular#41353
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The partial declaration of a component includes the list of directives
that are used in its template, including some metadata of the directive
which can be used during actual compilation of the component. This
commit introduces an additional metadata flag
isComponentsuch thattemplate compilation can use this information in the future.