feat(router): add migration for ActivatedRouteSnapshot.fragment#41092
Closed
crisbeto wants to merge 1 commit intoangular:masterfrom
Closed
feat(router): add migration for ActivatedRouteSnapshot.fragment#41092crisbeto wants to merge 1 commit intoangular:masterfrom
crisbeto wants to merge 1 commit intoangular:masterfrom
Conversation
14 tasks
2a3f2c3 to
2f6e2af
Compare
atscott
reviewed
Mar 9, 2021
2f6e2af to
8bf0d97
Compare
Contributor
|
Hi @crisbeto, first and foremost, thanks again for taking this on! I ran this migration in g3 and it was very helpful to identify that places that needed updates. I noticed a couple things:
|
8bf0d97 to
871f78a
Compare
Adds a migration that casts the value of `ActivatedRouteSnapshot.fragment` to be non-nullable. Also moves some code from the `AbstractControl.parent` migration so that it can be reused. Relates to angular#37336.
871f78a to
4420dae
Compare
Member
Author
|
@atscott I've reworked the migration so that it only applies to |
atscott
approved these changes
Mar 15, 2021
josephperrott
approved these changes
Mar 23, 2021
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: dev-infra
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Apr 5, 2021
…lar#41092) Adds a migration that casts the value of `ActivatedRouteSnapshot.fragment` to be non-nullable. Also moves some code from the `AbstractControl.parent` migration so that it can be reused. Relates to angular#37336. PR Close angular#41092
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a migration that casts the value of
ActivatedRouteSnapshot.fragmentto be non-nullable.Also moves some code from the
AbstractControl.parentmigration so that it can be reused.Relates to #37336.