docs(compiler-cli): add README.md for template type checking system#41004
Closed
alxhub wants to merge 1 commit intoangular:masterfrom
Closed
docs(compiler-cli): add README.md for template type checking system#41004alxhub wants to merge 1 commit intoangular:masterfrom
alxhub wants to merge 1 commit intoangular:masterfrom
Conversation
alxhub
added
action: merge
gkalpak
reviewed
Feb 26, 2021
Member
gkalpak
left a comment
gkalpak
left a comment
There was a problem hiding this comment.
This is just awesome 💯0️⃣0️⃣0️⃣
Member
There was a problem hiding this comment.
Suggested change
| During TCB generation, a numeric `TemplateId` is assigned to each template declared within a given input file. These `TemplateId` are attached in a comment to the TCBs for each template within the corresponding typecheck files. So the full algorithm for mapping a diagnostic back to the original template involves two steps: | |
| During TCB generation, a numeric `TemplateId` is assigned to each template declared within a given input file. These `TemplateId`s are attached in a comment to the TCBs for each template within the corresponding typecheck files. So the full algorithm for mapping a diagnostic back to the original template involves two steps: |
gkalpak
added
action: cleanup
JoostK
reviewed
Feb 26, 2021
Member
There was a problem hiding this comment.
Suggested change
| '' + user.name; | |
| '' + ctx.user.name; |
zarend
approved these changes
Feb 26, 2021
Contributor
zarend
left a comment
zarend
left a comment
There was a problem hiding this comment.
Thanks, I found these docs helpful.
zarend
added
the
area: compiler
This commit adds a semi-comprehensive README file which describes the design goals and implementation of the template type checking engine, which powers the Angular Language Service as well as the main compiler's understanding of types in templates.
alxhub
added
action: merge
alxhub
force-pushed
the
ngtsc/typecheck/readme
branch
from
a650d99 to
139e3de
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a semi-comprehensive README file which describes the
design goals and implementation of the template type checking engine,
which powers the Angular Language Service as well as the main compiler's
understanding of types in templates.