feat(language-service): Add diagnostics to suggest turning on strictTemplates by kyliau · Pull Request #40423 · angular/angular

kyliau · 2021-01-14T01:08:37Z

This PR creates a way for the language server to retrieve compiler options
diagnostics via languageService.getCompilerOptionsDiagnostics().

This will be used by the language server to show a prompt in the editor if
users don't have strictTemplates or fullTemplateTypeCheck turned on.

Ref angular/vscode-ng-language-service#1053

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

josephperrott

LGTM

packages/language-service/ivy/language_service.ts

atscott

reviewed-for: public-api

AndrewKushnir

Reviewed-for: public-api

zarend

👍

I did some bike-shedding on the exact copy of the diagnostic, but that's not a blocker for me :).

packages/language-service/ivy/language_service.ts

kyliau · 2021-01-22T00:18:49Z

presubmit: http://test/OCL:353126924:BASE:353126943:1611274712720:8d8cb1db

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts

petebacondarwin

Reviewed-for: public-api

…mode This PR adds a way for the language server to retrieve compiler options diagnostics via `languageService.getCompilerOptionsDiagnostics()`. This will be used by the language server to show a prompt in the editor if users don't have `strict` or `fullTemplateTypeCheck` turned on. Ref angular/vscode-ng-language-service#1053

jessicajaniuk · 2021-01-25T22:19:09Z

@kyliau This PR has conflicts with the 11.1.x branch. it's been retargeted to minor and merged into master only. Could you create a patch-only version of this PR to get it into 11.1.x?

angular-automatic-lock-bot · 2021-02-25T16:46:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes label Jan 14, 2021

kyliau requested a review from atscott January 14, 2021 01:08

pullapprove bot requested review from alxhub and josephperrott January 14, 2021 01:08

kyliau requested review from zarend and removed request for josephperrott January 14, 2021 01:08

kyliau added the target: minor This PR is targeted for the next minor release label Jan 14, 2021

pullapprove bot requested a review from josephperrott January 14, 2021 01:09

kyliau added the area: language-service Issues related to Angular's VS Code language service label Jan 14, 2021

ngbot bot added this to the Backlog milestone Jan 14, 2021

kyliau added the area: compiler Issues related to `ngc`, Angular's template compiler label Jan 14, 2021

kyliau force-pushed the suggest-strict-mode branch 3 times, most recently from 9696074 to 4ffd0c5 Compare January 14, 2021 17:13

josephperrott approved these changes Jan 14, 2021

View reviewed changes

atscott approved these changes Jan 14, 2021

View reviewed changes

packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved

kyliau force-pushed the suggest-strict-mode branch from f76888e to 658b730 Compare January 14, 2021 22:05

alxhub reviewed Jan 14, 2021

View reviewed changes

packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved

kyliau force-pushed the suggest-strict-mode branch from 658b730 to a3ca10b Compare January 20, 2021 22:46

kyliau requested a review from alxhub January 20, 2021 22:47

kyliau force-pushed the suggest-strict-mode branch 2 times, most recently from 1d52c8e to c6d8eac Compare January 21, 2021 22:13

alxhub reviewed Jan 21, 2021

View reviewed changes

packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved

alxhub approved these changes Jan 21, 2021

View reviewed changes

pullapprove bot requested review from AndrewKushnir, atscott, jessicajaniuk and petebacondarwin January 21, 2021 22:19

kyliau force-pushed the suggest-strict-mode branch from c6d8eac to eb1fae9 Compare January 21, 2021 22:23

atscott approved these changes Jan 21, 2021

View reviewed changes

pullapprove bot requested a review from jelbourn January 21, 2021 22:24

kyliau force-pushed the suggest-strict-mode branch from eb1fae9 to 207f43e Compare January 21, 2021 22:29

kyliau changed the title ~~feat(language-service): Add diagnostics to suggest turning on strict mode~~ feat(language-service): Add diagnostics to suggest turning on strictTemplates Jan 21, 2021

AndrewKushnir approved these changes Jan 21, 2021

View reviewed changes

pullapprove bot requested a review from alxhub January 21, 2021 23:10

zarend approved these changes Jan 21, 2021

View reviewed changes

packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved

kyliau force-pushed the suggest-strict-mode branch from 207f43e to ec0d416 Compare January 21, 2021 23:24

kyliau added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Jan 22, 2021

petebacondarwin reviewed Jan 22, 2021

View reviewed changes

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts Outdated Show resolved Hide resolved

pullapprove bot requested a review from petebacondarwin January 22, 2021 17:45

petebacondarwin approved these changes Jan 22, 2021

View reviewed changes

kyliau force-pushed the suggest-strict-mode branch from 3e70028 to 1db787e Compare January 22, 2021 17:51

kyliau removed request for jelbourn and jessicajaniuk January 22, 2021 18:30

alxhub approved these changes Jan 22, 2021

View reviewed changes

kyliau added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2021

jessicajaniuk force-pushed the suggest-strict-mode branch from 1db787e to 2f0eff5 Compare January 22, 2021 21:46

jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 22, 2021

jessicajaniuk closed this in ecae75f Jan 25, 2021

kyliau mentioned this pull request Jan 26, 2021

feat(language-service): Add diagnostics to suggest turning on strict … #40568

Closed

14 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(language-service): Add diagnostics to suggest turning on strictTemplates#40423

feat(language-service): Add diagnostics to suggest turning on strictTemplates#40423
kyliau wants to merge 1 commit intoangular:masterfrom
kyliau:suggest-strict-mode

kyliau commented Jan 14, 2021 •

edited

Loading

Uh oh!

josephperrott left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott left a comment

Uh oh!

AndrewKushnir left a comment

Uh oh!

zarend left a comment

Uh oh!

Uh oh!

kyliau commented Jan 22, 2021

Uh oh!

Uh oh!

petebacondarwin left a comment

Uh oh!

jessicajaniuk commented Jan 25, 2021

Uh oh!

angular-automatic-lock-bot bot commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

kyliau commented Jan 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

zarend left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kyliau commented Jan 22, 2021

Uh oh!

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk commented Jan 25, 2021

Uh oh!

angular-automatic-lock-bot bot commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kyliau commented Jan 14, 2021 •

edited

Loading