fix(http): complete the request on timeout#39807
Closed
arturovt wants to merge 1 commit intoangular:masterfrom
arturovt:fix/issue-26453
Closed
fix(http): complete the request on timeout#39807arturovt wants to merge 1 commit intoangular:masterfrom arturovt:fix/issue-26453
arturovt wants to merge 1 commit intoangular:masterfrom
arturovt:fix/issue-26453
Conversation
jessicajaniuk
approved these changes
Nov 23, 2020
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM. Thanks! This is very straightforward.
jessicajaniuk
added
action: presubmit
Contributor
jessicajaniuk
added
action: review
petebacondarwin
requested review from
alxhub
and removed request for
IgorMinar
petebacondarwin
added
the
action: presubmit
alxhub
approved these changes
Jan 29, 2021
When using the [timeout attribute](https://xhr.spec.whatwg.org/#the-timeout-attribute) and an XHR request times out, browsers trigger the `timeout` event (and execute the XHR's `ontimeout` callback). Additionally, Safari 9 handles timed-out requests in the same way, even if no `timeout` has been explicitly set on the XHR. In the above cases, `HttpClient` would fail to capture the XHR's completing (with an error), so the corresponding `Observable` would never complete. PR Close #26453
petebacondarwin
removed
the
action: review
jessicajaniuk
added
action: merge
14 tasks
alxhub
added
target: minor
Member
|
Merging just to |
Contributor
Author
Sure, I'll try that. |
6 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue Number: #26453
What is the new behavior?
Does this PR introduce a breaking change?