docs: Refactor-i18n-DOCS-758 by rockument69 · Pull Request #36924 · angular/angular

rockument69 · 2020-05-04T23:32:52Z

Rewrite headings to focus on tasks and separate reference info and best practices from tasks. Add missing steps or procedures, and links to important information. Make the example open in StackBlitz. See i18n Documentation Plan at https://docs.google.com/document/d/1aV2TKsIqry7JnNiHEfhmheu5rNAbNl1IRYVhYErc7Ks/edit?usp=sharing

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

As a page in Techniques, it should be task-oriented.
Headings focus on Angular features, not user tasks.
Some steps or procedures are missing.
Topic mixes tasks, best practices, and reference content.
Lack of linking with related topics.

Issue Number: DOCS-758

What is the new behavior?

Rewrote headings to focus on tasks and separated reference info and best practices from tasks. Added missing steps or procedures, and links to important information. Prepared the example to open in StackBlitz.

See i18n Documentation Plan

Does this PR introduce a breaking change?

Yes
No

Other information

mary-poppins · 2020-05-04T23:42:19Z

You can preview f18bc7b at https://pr36924-f18bc7b.ngbuilds.io/.

mary-poppins · 2020-05-06T23:44:01Z

You can preview 87c71c4 at https://pr36924-87c71c4.ngbuilds.io/.

mary-poppins · 2020-05-07T20:27:18Z

You can preview 36bc376 at https://pr36924-36bc376.ngbuilds.io/.

mary-poppins · 2020-05-11T22:31:48Z

You can preview 4f11d99 at https://pr36924-4f11d99.ngbuilds.io/.

mary-poppins · 2020-05-11T23:17:34Z

You can preview d63b502 at https://pr36924-d63b502.ngbuilds.io/.

mary-poppins · 2020-05-12T23:23:22Z

You can preview 9dc238b at https://pr36924-9dc238b.ngbuilds.io/.

mary-poppins · 2020-05-13T21:11:41Z

You can preview 3172889 at https://pr36924-3172889.ngbuilds.io/.

mary-poppins · 2020-05-13T23:27:05Z

You can preview b320fbe at https://pr36924-b320fbe.ngbuilds.io/.

petebacondarwin

Reviewed up to the "Prepare templates for translations" section.

mary-poppins · 2020-05-14T16:42:31Z

You can preview 1bd68a3 at https://pr36924-1bd68a3.ngbuilds.io/.

mary-poppins · 2020-05-14T23:23:57Z

You can preview 2061560 at https://pr36924-2061560.ngbuilds.io/.

petebacondarwin

I have reviewed up to the Prepare templates for translations section (exclusive). This reads much better and is accurate.

Should I continue to review further or wait?

rockument69 · 2020-05-15T15:13:51Z

Should I continue to review further or wait?

@petebacondarwin:
Go ahead and review the rest of the guide. I have edited it to the end. I will address all of your suggestions and changes today and Monday. Thanks!

mary-poppins · 2020-05-15T16:44:48Z

You can preview 98bc770 at https://pr36924-98bc770.ngbuilds.io/.

rockument69 · 2020-05-15T19:06:53Z

@petebacondarwin : All edits are done and commits squashed. This is the "finished draft" to review. I am also removing the WIP from the title. Thanks!

mary-poppins · 2020-06-17T17:15:27Z

You can preview 9278fff at https://pr36924-9278fff.ngbuilds.io/.

mary-poppins · 2020-06-17T20:42:57Z

You can preview 983cab4 at https://pr36924-983cab4.ngbuilds.io/.

petebacondarwin

Just a couple of last minute typos. Otherwise LGTM!
Thanks for you patience and diligence with this PR @rockument69

clydin

LGTM from a tooling perspective.

Rewrite headings to focus on tasks and separate reference info and best practices from tasks. Add missing steps or procedures, and links to important information. Make the example open in StackBlitz. See i18n Documentation Plan at https://docs.google.com/document/d/1aV2TKsIqry7JnNiHEfhmheu5rNAbNl1IRYVhYErc7Ks/edit?usp=sharing

mary-poppins · 2020-06-18T18:47:25Z

You can preview ebccd78 at https://pr36924-ebccd78.ngbuilds.io/.

angular-automatic-lock-bot · 2020-07-24T16:14:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label May 4, 2020

rockument69 force-pushed the rockument69-i18n-refactor branch 2 times, most recently from fe8eac8 to e7732c0 Compare May 6, 2020 23:23

petebacondarwin reviewed May 7, 2020

View reviewed changes

Comment thread aio/content/guide/i18n.md Outdated

rockument69 force-pushed the rockument69-i18n-refactor branch from 87c71c4 to 36bc376 Compare May 7, 2020 20:13

mhevery added the comp: docs label May 11, 2020

ngbot Bot added this to the needsTriage milestone May 11, 2020

rockument69 force-pushed the rockument69-i18n-refactor branch from 36bc376 to 4f11d99 Compare May 11, 2020 22:21

rockument69 force-pushed the rockument69-i18n-refactor branch from 9dc238b to 3172889 Compare May 13, 2020 21:02

petebacondarwin reviewed May 14, 2020

View reviewed changes

rockument69 force-pushed the rockument69-i18n-refactor branch from b320fbe to 1bd68a3 Compare May 14, 2020 16:30

petebacondarwin reviewed May 15, 2020

View reviewed changes

Comment thread aio/content/guide/i18n.md Outdated

Comment thread aio/content/guide/i18n.md Outdated

petebacondarwin reviewed May 15, 2020

View reviewed changes

rockument69 self-assigned this May 15, 2020

rockument69 force-pushed the rockument69-i18n-refactor branch from 2061560 to 98bc770 Compare May 15, 2020 16:36

rockument69 force-pushed the rockument69-i18n-refactor branch from 9147b6d to e6bea7b Compare May 15, 2020 19:04

rockument69 changed the title ~~[WIP] docs: Refactor-i18n-DOCS-758~~ docs: Refactor-i18n-DOCS-758 May 15, 2020

petebacondarwin reviewed Jun 16, 2020

View reviewed changes

Comment thread aio/tools/examples/shared/boilerplate/i18n/angular.json Outdated

petebacondarwin reviewed Jun 16, 2020

View reviewed changes

Comment thread aio/tools/examples/shared/boilerplate/i18n/package.json Outdated

petebacondarwin reviewed Jun 16, 2020

View reviewed changes

Comment thread aio/tools/examples/shared/package.json Outdated

aikithoughts requested a review from petebacondarwin June 17, 2020 15:31

petebacondarwin force-pushed the rockument69-i18n-refactor branch from d1051c3 to 9278fff Compare June 17, 2020 17:06

rockument69 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 17, 2020

petebacondarwin mentioned this pull request Jun 18, 2020

Does i18n angular app need to be builded for each of the suported language? #37634

Closed

petebacondarwin approved these changes Jun 18, 2020

View reviewed changes

Comment thread aio/content/guide/i18n.md Outdated

Comment thread aio/content/guide/i18n.md Outdated

petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 18, 2020

petebacondarwin assigned aikithoughts Jun 18, 2020

clydin approved these changes Jun 18, 2020

View reviewed changes

kapunahelewong force-pushed the rockument69-i18n-refactor branch from 983cab4 to ebccd78 Compare June 18, 2020 18:37

kapunahelewong added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 18, 2020

rockument69 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer state: needs doc team review labels Jun 22, 2020

This was linked to issues Jun 22, 2020

Internationalization (i18n) DOCS (& bugs)? #24849

Closed

Angular-i18n Guide #24474

Closed

rockument69 mentioned this pull request Jun 22, 2020

Angular-i18n Guide #24474

Closed

rockument69 linked an issue Jun 22, 2020 that may be closed by this pull request

DOCS-i18n: Select among alternative text translations #22522

Closed

rockument69 mentioned this pull request Jun 22, 2020

DOCS-i18n: Select among alternative text translations #22522

Closed

mhevery closed this in 7e0eccc Jun 22, 2020

rockument69 mentioned this pull request Jun 22, 2020

Internationalization (i18n) DOCS (& bugs)? #24849

Closed

gkalpak mentioned this pull request Jul 3, 2020

WIP - build(docs-infra): update docs examples to latest v9 and Ivy #34374

Closed

8 tasks

Conversation

rockument69 commented May 4, 2020

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented May 4, 2020

Uh oh!

mary-poppins commented May 6, 2020

Uh oh!

Uh oh!

mary-poppins commented May 7, 2020

Uh oh!

mary-poppins commented May 11, 2020

Uh oh!

mary-poppins commented May 11, 2020

Uh oh!

mary-poppins commented May 12, 2020

Uh oh!

mary-poppins commented May 13, 2020

Uh oh!

mary-poppins commented May 13, 2020

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented May 14, 2020

Uh oh!

mary-poppins commented May 14, 2020

Uh oh!

Uh oh!

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

rockument69 commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented May 15, 2020

Uh oh!

rockument69 commented May 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Jun 17, 2020

Uh oh!

mary-poppins commented Jun 17, 2020

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

clydin left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Jun 18, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Jul 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

rockument69 commented May 15, 2020 •

edited

Loading