Skip to content

fix(zone.js): remove unused Promise overwritten logic#36851

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:remove-promise-setter
Closed

fix(zone.js): remove unused Promise overwritten logic#36851
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:remove-promise-setter

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Apr 29, 2020 •
edited by mhevery
Loading

In the early Zone.js versions (< 0.10.3), ZoneAwarePromise did not support Symbol.species,
so when user used a 3rd party Promise such as es6-promise, and try to load the promise library after import of zone.js, the loading promise library will overwrite the patched Promise from zone.js and will break Promise semantics with respect to zone.js.

Starting with zone.js 0.10.3, Symbol.species is supported therefore this will not longer be an issue. (#34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of global.Promise, to allow the 3rd party libraries to override native Promise
instead of ZoneAwarePromise. This is not the correct solution, and since the Promise.species is now supported, the 3rd party solution of overriding global.Promise is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@JiaLiPassion JiaLiPassion requested a review from mhevery April 29, 2020 08:14
@AndrewKushnir AndrewKushnir added the area: zones Issues related to zone.js label Apr 29, 2020
@ngbot ngbot Bot added this to the needsTriage milestone Apr 29, 2020
mhevery
mhevery approved these changes Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message to:

In the early Zone.js versions (< 0.10.3), `ZoneAwarePromise` did not support `Symbol.species`,
so when user used a 3rd party `Promise` such as `es6-promise`, and try to load the promise library after import of `zone.js`, the loading promise library will overwrite the patched `Promise` from `zone.js` and will break `Promise` semantics with respect to `zone.js`.

Starting with `zone.js` 0.10.3, `Symbol.species` is supported therefore this will not longer be an issue. (https://github.com/angular/angular/pull/34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of `global.Promise`, to allow the 3rd party libraries to override native `Promise`
instead of `ZoneAwarePromise`. This is not the correct solution, and since the `Promise.species` is now supported, the 3rd party solution of overriding `global.Promise` is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)

@mhevery mhevery added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 30, 2020
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Apr 30, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    pending forbidden labels detected: PR action: cleanup
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JiaLiPassion JiaLiPassion force-pushed the remove-promise-setter branch from 88dfc43 to f08c541 Compare May 1, 2020 01:48
@JiaLiPassion JiaLiPassion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 1, 2020
@JiaLiPassion
Copy link
Copy Markdown
Contributor Author

JiaLiPassion commented May 1, 2020

@mhevery , got it, thank you, updated the commit messages.

@IgorMinar IgorMinar added action: presubmit The PR is in need of a google3 presubmit PR action: rerun CI at HEAD labels May 20, 2020
@JiaLiPassion JiaLiPassion force-pushed the remove-promise-setter branch from f08c541 to d3173e0 Compare June 11, 2020 22:17
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Jun 11, 2020

Hi @JiaLiPassion, FYI I've started a presubmit.

It looks like the test_ivy_aot CI job is failing due to the polyfills size limit change (actually size decrease, yay). Could you please update the payload limits to reflect that?

Thank you.

@JiaLiPassion
fix(zone.js): remove unused Promise overwritten setter logic
218fc59 
In the early Zone.js versions (< 0.10.3), `ZoneAwarePromise` did not support `Symbol.species`,
so when user used a 3rd party `Promise` such as `es6-promise`, and try to load the promise library after import of `zone.js`, the loading promise library will overwrite the patched `Promise` from `zone.js` and will break `Promise` semantics with respect to `zone.js`.

Starting with `zone.js` 0.10.3, `Symbol.species` is supported therefore this will not longer be an issue. (https://github.com//pull/34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of `global.Promise`, to allow the 3rd party libraries to override native `Promise` instead of `ZoneAwarePromise`. This is not the correct solution, and since the `Promise.species` is now supported, the 3rd party solution of overriding `global.Promise` is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)
@JiaLiPassion JiaLiPassion force-pushed the remove-promise-setter branch from d3173e0 to 218fc59 Compare June 12, 2020 01:50
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Jun 12, 2020

Failures seem unrelated.

mhevery pushed a commit that referenced this pull request Jun 12, 2020
@JiaLiPassion @mhevery
fix(zone.js): remove unused Promise overwritten setter logic (#36851)
c909e73 
In the early Zone.js versions (< 0.10.3), `ZoneAwarePromise` did not support `Symbol.species`,
so when user used a 3rd party `Promise` such as `es6-promise`, and try to load the promise library after import of `zone.js`, the loading promise library will overwrite the patched `Promise` from `zone.js` and will break `Promise` semantics with respect to `zone.js`.

Starting with `zone.js` 0.10.3, `Symbol.species` is supported therefore this will not longer be an issue. (https://github.com//pull/34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of `global.Promise`, to allow the 3rd party libraries to override native `Promise` instead of `ZoneAwarePromise`. This is not the correct solution, and since the `Promise.species` is now supported, the 3rd party solution of overriding `global.Promise` is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)

PR Close #36851
@mhevery mhevery closed this in 31796e8 Jun 12, 2020
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@JiaLiPassion @ngwattcos
fix(zone.js): remove unused Promise overwritten setter logic (angular…
cfa2179 
…#36851)

In the early Zone.js versions (< 0.10.3), `ZoneAwarePromise` did not support `Symbol.species`,
so when user used a 3rd party `Promise` such as `es6-promise`, and try to load the promise library after import of `zone.js`, the loading promise library will overwrite the patched `Promise` from `zone.js` and will break `Promise` semantics with respect to `zone.js`.

Starting with `zone.js` 0.10.3, `Symbol.species` is supported therefore this will not longer be an issue. (https://github.com//pull/34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of `global.Promise`, to allow the 3rd party libraries to override native `Promise` instead of `ZoneAwarePromise`. This is not the correct solution, and since the `Promise.species` is now supported, the 3rd party solution of overriding `global.Promise` is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)

PR Close angular#36851
@JiaLiPassion JiaLiPassion mentioned this pull request Jun 27, 2020
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Jul 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 13, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@JiaLiPassion @profanis
fix(zone.js): remove unused Promise overwritten setter logic (angular…
0450905 
…#36851)

In the early Zone.js versions (< 0.10.3), `ZoneAwarePromise` did not support `Symbol.species`,
so when user used a 3rd party `Promise` such as `es6-promise`, and try to load the promise library after import of `zone.js`, the loading promise library will overwrite the patched `Promise` from `zone.js` and will break `Promise` semantics with respect to `zone.js`.

Starting with `zone.js` 0.10.3, `Symbol.species` is supported therefore this will not longer be an issue. (https://github.com//pull/34533)

Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of `global.Promise`, to allow the 3rd party libraries to override native `Promise` instead of `ZoneAwarePromise`. This is not the correct solution, and since the `Promise.species` is now supported, the 3rd party solution of overriding `global.Promise` is no longer needed.

PR removes the wrong work around logic. (This will improve the bundle size.)

PR Close angular#36851
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub Awaiting requested review from alxhub

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@jelbourn jelbourn Awaiting requested review from jelbourn

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: zones Issues related to zone.js cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@JiaLiPassion @AndrewKushnir @mhevery @IgorMinar @googlebot