build: update jasmine to 3.5#36501
Conversation
|
|
fe55d99 to
0fb79f8
Compare
ayazhafiz
left a comment
There was a problem hiding this comment.
lgtm for language service
0fb79f8 to
c5c7e16
Compare
1. update jasmine to 3.5 2. update @types/jasmine to 3.5 3. update @types/jasminewd2 to 2.0.8 Also fix several cases, the new jasmine 3 will help to create test cases correctly, such as in the `jasmine 2.x` version, the following case will pass ``` expect(1 == 2); ``` But in jsamine 3, the case will need to be ``` expect(1 == 2).toBeTrue(); ``` Some cases will still need to use `spy as any` cast, because `@types/jasmine` have some issues, 1. The issue jasmine doesn't handle optional method properties, DefinitelyTyped/DefinitelyTyped#43486 2. The issue jasmine doesn't handle overload method correctly, DefinitelyTyped/DefinitelyTyped#42455
c5c7e16 to
aed1330
Compare
IgorMinar
left a comment
There was a problem hiding this comment.
Hi @JiaLiPassion, thanks for the PR but I'm a bit puzzled to be honest...
This PR doesn't actually "update to jasmine 3.5" - can you please clarify what you are trying to do?
| "@types/hammerjs": "2.0.35", | ||
| "@types/inquirer": "^6.5.0", | ||
| "@types/jasmine": "3.5.10", | ||
| "@types/jasmine": "^3.5.10", |
There was a problem hiding this comment.
why this change? it seems unnecessary and it's actually undesirable.
we found it easier know what we use if we pin the dependencies in package.json and manually update. Can you please roll back this change (and yarn.lock file).
|
@IgorMinar , thank you for the review. This PR is based on |
|
@IgorMinar , sorry for the confusion, it seems the PR #34625 has been merged into branch |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
based on PR #34625, this one will target
9.1.xbranch.Also fix several cases, the new jasmine 3 will help to create test cases correctly,
such as in the
jasmine 2.xversion, the following case will passBut in jsamine 3, the case will need to be
Some cases will still need to use
spy as anycast, because@types/jasminehave some issues,