style(zone.js): fix lint errors after clang update#36487
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
style(zone.js): fix lint errors after clang update#36487AndrewKushnir wants to merge 1 commit intoangular:masterfrom
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
Recent ZoneJS-related commit (angular@416c786) update the `promise.ts` file, but it looks like original PR was not rebased after clang update. As a result, the `lint` CircleCI job started to fail in master after merging that PR (angular#36311). This commit updates the format of the `promise.ts` script according to the new clang rules.
AndrewKushnir
added
action: review
kara
approved these changes
Apr 7, 2020
kara
added
action: merge
kara
pushed a commit
that referenced
this pull request
Apr 7, 2020
Recent ZoneJS-related commit (416c786) update the `promise.ts` file, but it looks like original PR was not rebased after clang update. As a result, the `lint` CircleCI job started to fail in master after merging that PR (#36311). This commit updates the format of the `promise.ts` script according to the new clang rules. PR Close #36487
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent ZoneJS-related commit (416c786) updated the
promise.tsfile, but it looks like original PR was not rebased after clang update. As a result, thelintCircleCI job started to fail in master after merging that PR (#36311). This commit updates the format of thepromise.tsscript according to the new clang rules.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?