fix(zone.js): should not try to patch fetch if it is not writable#36311
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): should not try to patch fetch if it is not writable#36311JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
added
area: zones
|
|
JiaLiPassion
force-pushed
the
fetch-readonly
branch
3 times, most recently
from
8b1e7ec to
f07b6dc
Compare
JiaLiPassion
changed the title
Close angular#36142 In Firefox extensions, the `window.fetch` is not configurable, that means ``` const desc = Object.getOwnPropertyDescriptor(window, 'fetch'); desc.writable === false; ``` So in this case, we should not try to patch `fetch`, otherwise, it will throw error ('fetch is ReadOnly`)
JiaLiPassion
force-pushed
the
fetch-readonly
branch
from
f07b6dc to
82c6324
Compare
mhevery
approved these changes
Mar 30, 2020
Contributor
Contributor
Author
|
@mhevery, it seems the G3 failed, could you post the errors? thanks. |
Contributor
Unrelated failure, forcing green. |
kara
pushed a commit
that referenced
this pull request
Apr 6, 2020
…6311) Close #36142 In Firefox extensions, the `window.fetch` is not configurable, that means ``` const desc = Object.getOwnPropertyDescriptor(window, 'fetch'); desc.writable === false; ``` So in this case, we should not try to patch `fetch`, otherwise, it will throw error ('fetch is ReadOnly`) PR Close #36311
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Apr 7, 2020
Recent ZoneJS-related commit (angular@416c786) update the `promise.ts` file, but it looks like original PR was not rebased after clang update. As a result, the `lint` CircleCI job started to fail in master after merging that PR (angular#36311). This commit updates the format of the `promise.ts` script according to the new clang rules.
3 tasks
kara
pushed a commit
that referenced
this pull request
Apr 7, 2020
Recent ZoneJS-related commit (416c786) update the `promise.ts` file, but it looks like original PR was not rebased after clang update. As a result, the `lint` CircleCI job started to fail in master after merging that PR (#36311). This commit updates the format of the `promise.ts` script according to the new clang rules. PR Close #36487
kara
pushed a commit
that referenced
this pull request
Apr 7, 2020
Recent ZoneJS-related commit (416c786) update the `promise.ts` file, but it looks like original PR was not rebased after clang update. As a result, the `lint` CircleCI job started to fail in master after merging that PR (#36311). This commit updates the format of the `promise.ts` script according to the new clang rules. PR Close #36487
|
@JiaLiPassion @mhevery when will this merged? Im asking because of this PR has just a merge label. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #36142
In Firefox extensions, the
window.fetchis not configurable, that meansSo in this case, we should not try to patch
fetch, otherwise, it willthrow error ('fetch is ReadOnly`)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?