fix(zone.js): fix 2 bluebird test cases for each/mapSeries#36295
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): fix 2 bluebird test cases for each/mapSeries#36295JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
added
area: zones
JiaLiPassion
force-pushed
the
bluebird-tets-fix
branch
2 times, most recently
from
ac12a24 to
ab4f9b0
Compare
mhevery
approved these changes
Mar 30, 2020
mhevery
added
action: cleanup
`Bluebird.each` and `Bluebird.mapSeries` will accept a callback with `value` parameter,
the `value` should be the item in the array, not array itself.
For example:
```
const arr = [1, 2];
Bluebird.each(arr, function(value, idx) {
console.log(`value: ${value}, idx: ${idx}`);
})
```
the output will be
```
value: 1, idx: 0
value: 2, idx: 1
```
This PR fix the test cases for `each` and `mapSeries` APIs.
JiaLiPassion
force-pushed
the
bluebird-tets-fix
branch
from
ab4f9b0 to
5cca711
Compare
JiaLiPassion
removed
the
action: cleanup
alxhub
pushed a commit
that referenced
this pull request
Mar 31, 2020
`Bluebird.each` and `Bluebird.mapSeries` will accept a callback with `value` parameter,
the `value` should be the item in the array, not array itself.
For example:
```
const arr = [1, 2];
Bluebird.each(arr, function(value, idx) {
console.log(`value: ${value}, idx: ${idx}`);
})
```
the output will be
```
value: 1, idx: 0
value: 2, idx: 1
```
This PR fix the test cases for `each` and `mapSeries` APIs.
PR Close #36295
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bluebird.eachandBluebird.mapSerieswill accept a callback withvalueparameter,the
valueshould be the item in the array, not array itself.For example:
the output will be
This PR fix the test cases for
eachandmapSeriesAPIs.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?