fix(zone.js): zone.js patches rxjs should check null for unsubscribe#35990
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): zone.js patches rxjs should check null for unsubscribe#35990JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
added
area: zones
mhevery
suggested changes
Mar 10, 2020
JiaLiPassion
force-pushed
the
zone-rxjs-patch-null-check
branch
from
3acdd4e to
d505a69
Compare
JiaLiPassion
force-pushed
the
zone-rxjs-patch-null-check
branch
3 times, most recently
from
746c068 to
b4d65b6
Compare
mhevery
approved these changes
Mar 11, 2020
Contributor
mhevery
left a comment
mhevery
left a comment
There was a problem hiding this comment.
I am really sorry but I am going to ask you to go back to previous code, as I miss-understood the test. Really sorry about that.
LGTM and leaving cleanup.
Remove cleanup after fixed.
mhevery
added
action: cleanup
Close angular#31687, angular#31684 Zone.js patches rxjs internal `_subscribe` and `_unsubscribe` methods, but zone.js doesn't do null check, so in some operator such as `retryWhen`, the `_unsubscribe` will be set to null, and will cause zone patched version throw error. In this PR, if `_subscribe` and `_unsubscribe` is null, will not do the patch.
JiaLiPassion
force-pushed
the
zone-rxjs-patch-null-check
branch
from
b4d65b6 to
e0e7859
Compare
JiaLiPassion
removed
the
action: cleanup
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
removed
the
action: presubmit
Contributor
|
FYI, changes in this PR were tested against g3 as a part of #36043, using Global TAP run, which was successful. Thank you. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 16, 2020
…35990) Close #31687, #31684 Zone.js patches rxjs internal `_subscribe` and `_unsubscribe` methods, but zone.js doesn't do null check, so in some operator such as `retryWhen`, the `_unsubscribe` will be set to null, and will cause zone patched version throw error. In this PR, if `_subscribe` and `_unsubscribe` is null, will not do the patch. PR Close #35990
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #31687, #31684
Zone.js patches rxjs
_subscribeand_unsubscribemethods, but zone.js doesn't do null check,so in some operator such as
retryWhen, the_unsubscribewill be set to null, and will causezone patched version throw error.
In this PR, if
_subscribeand_unsubscribeis null, will not do the patch.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?