fix: fix flaky test cases of passive events#35679
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix: fix flaky test cases of passive events#35679JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
force-pushed
the
passive-test-flaky
branch
from
bc1c991 to
575e9c4
Compare
14 tasks
JiaLiPassion
force-pushed
the
passive-test-flaky
branch
from
575e9c4 to
ac5ab17
Compare
JiaLiPassion
force-pushed
the
passive-test-flaky
branch
from
ac5ab17 to
d44aa71
Compare
JiaLiPassion
force-pushed
the
passive-test-flaky
branch
from
d44aa71 to
4c24456
Compare
JiaLiPassion
added
the
target: patch
mhevery
approved these changes
Mar 5, 2020
matsko
added
target: major
Contributor
|
@JiaLiPassion this doesn't merge onto the patch branch properly. I changed it so that it only gets applied to the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The test case will random failed like this, https://circleci.com/gh/angular/angular/634629?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification, the reason is the
eventListenersare not cleared, and jasmine now run test cases in random orders, so some time, the eventListener of other test cases will be triggered.What is the new behavior?
clear all event listeners when running cases.
Does this PR introduce a breaking change?
Other information