Skip to content

feat: update mocha patch as zone module#34719

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:mocha-module
Closed

feat: update mocha patch as zone module#34719
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:mocha-module

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Jan 10, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

make mocha patch a zone module, so we can load jasmine/mocha/jest all into zone-testing bundle, and disable them if not needed.

@JiaLiPassion JiaLiPassion requested a review from a team January 10, 2020 09:15
@JiaLiPassion JiaLiPassion force-pushed the mocha-module branch 2 times, most recently from 6358739 to d8b4840 Compare January 10, 2020 10:01
@atscott atscott added the area: zones Issues related to zone.js label Jan 14, 2020
@ngbot ngbot Bot added this to the needsTriage milestone Jan 14, 2020
@JiaLiPassion JiaLiPassion added the target: patch This PR is targeted for the next patch release label Jan 30, 2020
@JiaLiPassion JiaLiPassion force-pushed the mocha-module branch 3 times, most recently from eade832 to 93135fd Compare January 31, 2020 15:15
mhevery
mhevery suggested changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can we add some documentation so that the users can discover this feature?

@JiaLiPassion
Copy link
Copy Markdown
Contributor Author

JiaLiPassion commented Feb 5, 2020

@mhevery, thanks for the review, I added the doc to describe how to disable jasmine/mocha patch.
And I will add follow up PR to describe how to test Angular with Mocha.

@JiaLiPassion JiaLiPassion mentioned this pull request Feb 5, 2020
Closed
12 tasks
@mhevery mhevery added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release labels Feb 5, 2020
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Feb 5, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    failure status "ci/circleci: saucelabs_ivy" is failing
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Feb 6, 2020

presubmit

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 7, 2020
@kara kara removed the request for review from pkozlowski-opensource February 7, 2020 19:43
@kara
Copy link
Copy Markdown
Contributor

kara commented Feb 7, 2020

@JiaLiPassion Can you rebase this? :)

@JiaLiPassion JiaLiPassion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 8, 2020
@JiaLiPassion
Copy link
Copy Markdown
Contributor Author

JiaLiPassion commented Feb 8, 2020

@kara, I just rebased, thanks!

@kara
Copy link
Copy Markdown
Contributor

kara commented Feb 11, 2020

new presubmit

@kara kara added action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 11, 2020
@kara kara closed this in 332937e Feb 11, 2020
@AndrewKushnir AndrewKushnir mentioned this pull request Mar 3, 2020
Closed
3 tasks
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Mar 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mhevery mhevery mhevery approved these changes

@filipesilva filipesilva filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@JiaLiPassion @mhevery @kara @filipesilva @atscott @googlebot