Fix nav focus active styles#34634
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
ad81207 to
2cbe888
Compare
|
@gkalpak The e2e tests are failing on circleci but running fine on my end. Can you take a look at that please? |
|
As discussed "offline", this seems to be caused by difference in Chrome's rendering between Windows and Linux/macOS. @sonukapoor is looking into it. |
|
You can preview ad81207 at https://pr34634-ad81207.ngbuilds.io/. |
2cbe888 to
ad8bd2a
Compare
ad8bd2a to
1cf604e
Compare
|
@gkalpak can we proceed with this? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #33239
Improved focus styles for topnav and footer including visible color.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #33239
What is the new behavior?
Topnav:

Footer:

Does this PR introduce a breaking change?
Other information
This PR builds on top of #33255