Skip to content

Fix nav focus active styles#34634

Closed
sonukapoor wants to merge 4 commits intoangular:masterfrom
sonukapoor:fix-nav-focus-active-styles
Closed

Fix nav focus active styles#34634
sonukapoor wants to merge 4 commits intoangular:masterfrom
sonukapoor:fix-nav-focus-active-styles

Conversation

@sonukapoor
Copy link
Copy Markdown
Contributor

Fixes #33239

Improved focus styles for topnav and footer including visible color.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #33239

What is the new behavior?

Topnav:
header

Footer:
footer

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR builds on top of #33255

@sonukapoor sonukapoor requested a review from a team January 3, 2020 14:54
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@sonukapoor
Copy link
Copy Markdown
Contributor Author

@googlebot I consent.

@sonukapoor sonukapoor force-pushed the fix-nav-focus-active-styles branch from ad81207 to 2cbe888 Compare January 3, 2020 18:39
@sonukapoor
Copy link
Copy Markdown
Contributor Author

@gkalpak The e2e tests are failing on circleci but running fine on my end. Can you take a look at that please?

@ngbot ngbot Bot added this to the needsTriage milestone Jan 7, 2020
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jan 9, 2020

As discussed "offline", this seems to be caused by difference in Chrome's rendering between Windows and Linux/macOS. @sonukapoor is looking into it.

@mary-poppins
Copy link
Copy Markdown

@sonukapoor sonukapoor force-pushed the fix-nav-focus-active-styles branch from 2cbe888 to ad8bd2a Compare January 18, 2020 20:57
@sonukapoor sonukapoor force-pushed the fix-nav-focus-active-styles branch from ad8bd2a to 1cf604e Compare January 18, 2020 21:05
@mary-poppins
Copy link
Copy Markdown

@mary-poppins
Copy link
Copy Markdown

@sonukapoor
Copy link
Copy Markdown
Contributor Author

@gkalpak can we proceed with this?

@sonukapoor sonukapoor closed this Feb 19, 2020
@sonukapoor sonukapoor deleted the fix-nav-focus-active-styles branch February 19, 2020 02:58
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top Menu highlight wrong item after click on browser back button

6 participants