I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "ci/circleci: test_ivy_aot" is failing
     missing required labels: PR target: *
     forbidden labels detected: PR action: cleanup
     status "ci/circleci: components-repo-unit-tests" is pending
     status "ci/circleci: test" is pending
     status "ci/circleci: test_aio" is pending
     status "ci/circleci: test_aio_local" is pending
     status "ci/circleci: test_aio_local_viewengine" is pending
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery , thanks, the test failed because there is a flaky cases, I fixed it here, #35679

presubmit

FYI, the changes from this PR caused some failures in g3, so the changes were reverted from master (in 71309d2). I'm re-opening this ticket.

cc @matsko

@AndrewKushnir , could you tell me more information about the failure in g3, because this PR should have no impact for the current code, this PR just build a new bundle , and this bundle will not be loaded by default. Thanks!

Hi @JiaLiPassion,

If I understand correctly, all files in the browser folder are included (except excluded ones), here is a snippet from the Angular BUILD file in g3:

ts_library(
    name = "zonejs_lib",
    srcs = glob(
        [
            "packages/zone.js/lib/browser/*.ts",
        ],
        exclude = [
            "packages/zone.js/lib/browser/rollup-*.ts",
            "packages/zone.js/lib/browser/shadydom.ts",
            "packages/zone.js/lib/browser/utils.ts",
            "packages/zone.js/lib/browser/webapis-*.ts",
        ],
    ) + [
        "packages/zone.js/lib/zone-spec/long-stack-trace.ts",
        "packages/zone.js/lib/zone-spec/wtf.ts",
    ],
    ...
)

So the newly added packages/zone.js/lib/browser/message-port.ts was also included and as a result affected some code.

Should it be in the exclude list?

Thank you.

@AndrewKushnir , oh, yes, I see the code snippet also exclude webapi-* so this messageport should also be excluded. This is an optional packages, so I think g3 doesn't need this file to be compiled.
Thanks.

Hi @JiaLiPassion, thanks for the update. Could you please rebase this PR, so that we re-run CI again and I'll try to run presubmit (excluding the file) in g3 again. Thank you.

@AndrewKushnir , sure, I have rebased this PR, please review, thanks!

@JiaLiPassion thanks for the update.

FYI, in order to run tests for ZoneJS changes that are in the merge queue, I've combined 4 ZoneJS PRs into one: #36043. Note: the #36043 PR is for testing purposes only and the changes will land in the corresponding PRs once g3 testing is completed.

Thank you.

@AndrewKushnir, got it, thank you!

FYI, changes in this PR were tested against g3 as a part of #36043, using Global TAP run, which was successful. Thank you.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}