fix: should also allow subclass Promise without Symbol.species#34533
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix: should also allow subclass Promise without Symbol.species#34533JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
13 tasks
JiaLiPassion
added
the
target: patch
mhevery
approved these changes
Jan 29, 2020
AndrewKushnir
added
the
action: presubmit
Contributor
AndrewKushnir
added
the
action: cleanup
Contributor
Author
|
@AndrewKushnir, thanks for the review, I have updated the PR. |
JiaLiPassion
force-pushed
the
promise-subclass
branch
from
1f54e56 to
e5e99cb
Compare
JiaLiPassion
removed
the
action: cleanup
JiaLiPassion
force-pushed
the
promise-subclass
branch
from
e5e99cb to
afb4def
Compare
alfaproject
reviewed
Jan 31, 2020
JiaLiPassion
force-pushed
the
promise-subclass
branch
from
afb4def to
cd8d07e
Compare
Contributor
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #34162
This is a regression issue introduced by #34162, before that PR, we call
this.constructorinPromise.then()to create a new Promise.In the #34162 PR, ZoneAwarePromise support to subclass Promise by Symbol.species.
But we still need to support subclass without Symbol.species implemented.
What is the new behavior?
If the subclass doesn't have Symbol.species, we should use
this.constructorinstead of hardcodedZoneAwarePromise.Does this PR introduce a breaking change?