fix(ivy): add attributes and classes to host elements based on selector by AndrewKushnir · Pull Request #34481 · angular/angular

AndrewKushnir · 2019-12-19T00:58:49Z

In View Engine, host element of dynamically created component received attributes and classes extracted from component's selector. For example, if component selector is [attr] .class, the attr attribute and .class class will be add to host element. This commit adds similar logic to Ivy, to make sure this behavior is aligned with View Engine.

This PR resolves #35445.

PR Type

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change?

Yes
No

AndrewKushnir · 2019-12-19T00:59:58Z

Note: this PR is blocked on PR #34450, since functions that work with selectors (in this PR and in PR #34450) should be combined/refactored.

kara

Thanks for picking this up! Some thoughts below

AndrewKushnir · 2020-02-05T20:58:56Z

Thanks for the review @kara. I've updated the code according to the comments/suggestions. Could you please have another look when you get a chance? Thank you.

pkozlowski-opensource · 2020-02-14T12:47:39Z

@AndrewKushnir in the description of this PR you've referenced issue #34256 but #34256 is closed now (and looks like a bit different issue from what this PR is solving?).

On the other hand it seems like this PR should fix #35445

AndrewKushnir · 2020-02-14T18:22:48Z

@pkozlowski-opensource issue #34256 was resolved by a different PR (#35136, to fix namespaces issue with dynamically created components). You are right, the problem described in the #35445 should be fixed by the changes in this PR. I've rebased it, waiting for final review from Kara. Thank you.

AndrewKushnir · 2020-02-18T19:05:27Z

Presubmit

kara

LGTM

In View Engine, host element of dynamically created component received attributes and classes extracted from component's selector. For example, if component selector is `[attr] .class`, the `attr` attribute and `.class` class will be add to host element. This commit adds similar logic to Ivy, to make sure this behavior is aligned with View Engine.

… selector

…or (#34481) In View Engine, host element of dynamically created component received attributes and classes extracted from component's selector. For example, if component selector is `[attr] .class`, the `attr` attribute and `.class` class will be add to host element. This commit adds similar logic to Ivy, to make sure this behavior is aligned with View Engine. PR Close #34481

This commit updates AIO payload size limit that is triggering a problem after merging angular@f95b8ce. That commit added some payload size, but all checks were "green" for the PR (angular#34481) after rebase that happened a couple hours before the merge, so this is an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master and patch branches back to "green" state.

This commit updates AIO payload size limit that is triggering a problem after merging f95b8ce. That commit added some payload size, but all checks were "green" for the PR (#34481) after rebase that happened a couple hours before the merge, so this is an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master and patch branches back to "green" state. PR Close #35538

angular-automatic-lock-bot · 2020-03-21T16:06:24Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir added type: bug/fix state: blocked target: patch This PR is targeted for the next patch release comp: ivy labels Dec 19, 2019

ngbot Bot added this to the needsTriage milestone Dec 19, 2019

googlebot added the cla: yes label Dec 19, 2019

AndrewKushnir force-pushed the selector_attrs_and_classes branch 2 times, most recently from 8bf5584 to b6156f9 Compare January 15, 2020 18:18

pullapprove Bot requested a review from alxhub January 29, 2020 20:25

AndrewKushnir removed the request for review from alxhub January 31, 2020 00:46

pullapprove Bot requested a review from alxhub January 31, 2020 00:46

AndrewKushnir force-pushed the selector_attrs_and_classes branch from b6156f9 to 947db2c Compare January 31, 2020 00:47

AndrewKushnir added state: WIP and removed state: blocked labels Jan 31, 2020

AndrewKushnir force-pushed the selector_attrs_and_classes branch 2 times, most recently from 8a5350c to 4362bd1 Compare February 1, 2020 03:13

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Feb 1, 2020

AndrewKushnir requested a review from kara February 1, 2020 03:14

AndrewKushnir marked this pull request as ready for review February 1, 2020 03:14

AndrewKushnir mentioned this pull request Feb 1, 2020

[RC5 IVY] Nested SVG doesn't work anymore #34256

Closed

kara suggested changes Feb 3, 2020

View reviewed changes

AndrewKushnir force-pushed the selector_attrs_and_classes branch 2 times, most recently from 4b37ae3 to 006690d Compare February 5, 2020 20:53

AndrewKushnir removed the request for review from alxhub February 5, 2020 20:58

pkozlowski-opensource mentioned this pull request Feb 14, 2020

Ivy: Component's class and attribute selectors are missing in created html element when router outlet is used #35445

Closed

AndrewKushnir force-pushed the selector_attrs_and_classes branch from cf5b06d to a7715e7 Compare February 14, 2020 18:18

AndrewKushnir force-pushed the selector_attrs_and_classes branch 2 times, most recently from af16106 to 82bea75 Compare February 14, 2020 19:36

kara reviewed Feb 14, 2020

View reviewed changes

Comment thread packages/core/src/render3/component_ref.ts Outdated

kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 18, 2020

kara assigned AndrewKushnir Feb 18, 2020

AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 18, 2020

kara approved these changes Feb 18, 2020

View reviewed changes

Comment thread packages/core/test/acceptance/view_container_ref_spec.ts Outdated

kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 18, 2020

kara unassigned AndrewKushnir Feb 18, 2020

AndrewKushnir force-pushed the selector_attrs_and_classes branch from 1a38e83 to fabe7e7 Compare February 18, 2020 21:37

AndrewKushnir added 2 commits February 18, 2020 13:37

fixup! fix(ivy): add attributes and classes to host elements based on…

16cd18e

… selector

AndrewKushnir force-pushed the selector_attrs_and_classes branch from fabe7e7 to 16cd18e Compare February 18, 2020 21:37

alxhub closed this in f95b8ce Feb 19, 2020

AndrewKushnir mentioned this pull request Feb 19, 2020

ci: increase AIO payload size limit #35538

Closed

3 tasks

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ivy): add attributes and classes to host elements based on selector#34481

fix(ivy): add attributes and classes to host elements based on selector#34481
AndrewKushnir wants to merge 2 commits intoangular:masterfrom
AndrewKushnir:selector_attrs_and_classes

AndrewKushnir commented Dec 19, 2019 •

edited

Loading

Uh oh!

AndrewKushnir commented Dec 19, 2019

Uh oh!

kara left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Feb 5, 2020

Uh oh!

pkozlowski-opensource commented Feb 14, 2020

Uh oh!

AndrewKushnir commented Feb 14, 2020

Uh oh!

Uh oh!

AndrewKushnir commented Feb 18, 2020 •

edited

Loading

Uh oh!

kara left a comment

Uh oh!

Uh oh!

angular-automatic-lock-bot Bot commented Mar 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AndrewKushnir commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Does this PR introduce a breaking change?

Uh oh!

AndrewKushnir commented Dec 19, 2019

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Feb 5, 2020

Uh oh!

pkozlowski-opensource commented Feb 14, 2020

Uh oh!

AndrewKushnir commented Feb 14, 2020

Uh oh!

Uh oh!

AndrewKushnir commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

angular-automatic-lock-bot Bot commented Mar 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndrewKushnir commented Dec 19, 2019 •

edited

Loading

AndrewKushnir commented Feb 18, 2020 •

edited

Loading