Add elements project type for boilerplate example projects by yallen011 · Pull Request #33484 · angular/angular

yallen011 · 2019-10-30T03:13:17Z

Added elements project type to the boilerplate sample projects to fix the issue with the angular elements example project in the Angular docs needing to be updated due to the angular elements package not being present in the package.json file when the zip file is downloaded.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

When downloading the zip from the https://angular.io/generated/zips/elements/elements.zip the @angular/elements package is not included in the package.json

Issue Number: #31332

What is the new behavior?

the @angular/elements package should now be included when downloading the following zip mentioned above.

Does this PR introduce a breaking change?

Yes
No

Other information

googlebot · 2019-10-30T03:13:28Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

yallen011 · 2019-10-30T03:45:27Z

@googlebot I fixed it.

googlebot · 2019-10-30T03:45:31Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-11-11T09:23:41Z

You can preview 47d859d at https://pr33484-47d859d.ngbuilds.io/.
You can preview 8c0699d at https://pr33484-8c0699d.ngbuilds.io/.
You can preview 61c9fe8 at https://pr33484-61c9fe8.ngbuilds.io/.
You can preview 66e1a17 at https://pr33484-66e1a17.ngbuilds.io/.

petebacondarwin

Great first PR @yallen011 !!

One small change please. In the commit message you don't need to add the PR Close #31332 line.
Our merge script will add this line with a link back to this PR. Please can change that line in your commit message to

Fixes #31332

gkalpak

Thx, @yallen011 ✨
I left a couple more comments, but otherwise this lgtm 👍

yallen011 · 2019-11-13T03:47:28Z

Ok, I will make the changes and resubmit.

gkalpak

One minor comment, but otherwise lgtm 🎉
Also, please, update the commit message (which is already in a pretty good form) to more closely follow our guidelines:

fix(docs-infra): add boilerplate path and project type for elements example project

Fixes #31332

gkalpak · 2019-11-18T12:32:28Z

Incorrect aplhabetic order: core should be above elements 😃

gkalpak · 2019-11-18T12:36:45Z

Oh, also, please rebase on master to make CI green.

yallen011 · 2019-11-19T03:15:06Z

Hi @gkalpak I read the doc for the commit message again, but I'm not sure what needs to be modified.

gkalpak · 2019-11-19T09:28:50Z

I've included a suggested commit message in my previous comment 😃 #33484 (review)

gkalpak · 2019-11-19T09:52:16Z

BTW, it seems you also need to rebase on master to make CI green. (You can follow the instructions in #33829 (comment).)

yallen011 · 2019-11-19T13:52:56Z

Ok, I see. I misread the comment asking me to change Closes to Fixes I read it as remove that part all together. I will update code and comment then rebase.

gkalpak · 2019-11-19T16:11:41Z

Both Closes and Fixes (and a few others) work. The important part is to include it on a new line on its own, at the bottom of the commit message, separated by an empty line from the rest of the message.

The current commit message is:

fix(docs-infra): add boilerplate path and project type for elements example project (#31332)

My suggestion is to change it to:

fix(docs-infra): add boilerplate path and project type for elements example project

Fixes #31332

(LMK if you run into difficulties updating the commit message or rebasing. Thx again for working on this 👍)

yallen011 · 2019-11-19T16:23:25Z

@gkalpak that's the way I had it at first. On a new line at the bottom of the commit message.

gkalpak · 2019-11-19T17:04:58Z

@yallen011, according to GitHub this is the initial PR commit 🤷‍♂
Maybe something got messed up during rebasing/amending?

yallen011 · 2019-11-22T04:23:34Z

ok, updated changes and forced pushed to kick off CI job

mary-poppins · 2019-11-22T04:28:03Z

You can preview 1728e63 at https://pr33484-1728e63.ngbuilds.io/.

ajitsinghkaler · 2020-03-06T04:45:21Z

@gkalpak I think this commit is ready to merge can you please have a look

ngbot · 2020-03-06T11:39:37Z

I see that you just added the PR action: merge label, but the following checks are still failing:
status "pullapprove" is failing
1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

gkalpak

Thx for making the changes, @yallen011! LGTM ✨
I've totally missed that I needed to re-review this. Thx for the ping, @ajitsinghkaler 👍

matsko · 2020-03-06T17:36:26Z

@yallen011 please rebase.

…xample project Fixes angular#31332

gkalpak · 2020-03-10T11:41:32Z

Rebased on master.

mary-poppins · 2020-03-10T11:51:54Z

You can preview 4b8f7fe at https://pr33484-4b8f7fe.ngbuilds.io/.

AndrewKushnir · 2020-03-10T21:27:20Z

@gkalpak do we need to update Angular package versions from ^8.0.0 to ^9.0.0?

gkalpak · 2020-03-11T10:48:12Z

@AndrewKushnir, this should be merged as is (to be consistent with the rest of the examples). I am updating the examples to v9/Ivy in #34374.

…xample project (#33484) Fixes #31332 PR Close #33484

angular-automatic-lock-bot · 2020-04-11T16:06:52Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

yallen011 requested a review from a team October 30, 2019 03:13

googlebot added the cla: no label Oct 30, 2019

yallen011 changed the title ~~Add elements project type for boilerplate sample projects~~ Add elements project type for boilerplate example projects Oct 30, 2019

googlebot added cla: yes and removed cla: no labels Oct 30, 2019

kapunahelewong added comp: docs effort2: days target: patch This PR is targeted for the next patch release risk: low feature Label used to distinguish feature request from other issues labels Oct 30, 2019

ngbot Bot modified the milestone: Backlog Oct 30, 2019

kapunahelewong requested a review from gkalpak October 30, 2019 16:41

yallen011 force-pushed the aio_elements_ex_prj_type branch from 47d859d to 8c0699d Compare October 31, 2019 02:10

yallen011 requested a review from a team October 31, 2019 02:33

yallen011 force-pushed the aio_elements_ex_prj_type branch from 61c9fe8 to 66e1a17 Compare October 31, 2019 03:30

petebacondarwin added the aio: preview label Nov 11, 2019

petebacondarwin approved these changes Nov 11, 2019

View reviewed changes

petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 11, 2019

gkalpak suggested changes Nov 11, 2019

View reviewed changes

Comment thread aio/tools/examples/example-boilerplate.js Outdated

Comment thread aio/tools/examples/shared/boilerplate/elements/angular.json Outdated

Comment thread aio/tools/examples/shared/boilerplate/elements/package.json Outdated

gkalpak suggested changes Nov 18, 2019

View reviewed changes

yallen011 force-pushed the aio_elements_ex_prj_type branch from c082cf0 to 1728e63 Compare November 22, 2019 04:17

gkalpak mentioned this pull request Mar 6, 2020

WIP - build(docs-infra): update docs examples to latest v9 and Ivy #34374

Closed

8 tasks

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 6, 2020

gkalpak approved these changes Mar 6, 2020

View reviewed changes

fix(docs-infra): add boilerplate path and project type for elements e…

4b8f7fe

…xample project Fixes angular#31332

gkalpak force-pushed the aio_elements_ex_prj_type branch from 1728e63 to 4b8f7fe Compare March 10, 2020 11:40

gkalpak mentioned this pull request Mar 11, 2020

build(docs-infra): update docs examples to latest v9 #36015

Closed

matsko pushed a commit that referenced this pull request Mar 11, 2020

fix(docs-infra): add boilerplate path and project type for elements e…

e262962

…xample project (#33484) Fixes #31332 PR Close #33484

matsko closed this in 5af0e75 Mar 11, 2020

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 11, 2020

Conversation

yallen011 commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

googlebot commented Oct 30, 2019

Uh oh!

yallen011 commented Oct 30, 2019

Uh oh!

googlebot commented Oct 30, 2019

Uh oh!

mary-poppins commented Nov 11, 2019

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yallen011 commented Nov 13, 2019

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak Nov 18, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Nov 18, 2019

Uh oh!

yallen011 commented Nov 19, 2019

Uh oh!

gkalpak commented Nov 19, 2019

Uh oh!

gkalpak commented Nov 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yallen011 commented Nov 19, 2019

Uh oh!

gkalpak commented Nov 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yallen011 commented Nov 19, 2019

Uh oh!

gkalpak commented Nov 19, 2019

Uh oh!

yallen011 commented Nov 22, 2019

Uh oh!

mary-poppins commented Nov 22, 2019

Uh oh!

ajitsinghkaler commented Mar 6, 2020

Uh oh!

ngbot Bot commented Mar 6, 2020

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

matsko commented Mar 6, 2020

Uh oh!

gkalpak commented Mar 10, 2020

Uh oh!

mary-poppins commented Mar 10, 2020

Uh oh!

AndrewKushnir commented Mar 10, 2020

Uh oh!

gkalpak commented Mar 11, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Apr 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

yallen011 commented Oct 30, 2019 •

edited

Loading

gkalpak commented Nov 19, 2019 •

edited

Loading

gkalpak commented Nov 19, 2019 •

edited

Loading