fix(docs-infra): use .tooltip and highlight the currently active node in top-bar#33351
Closed
gkalpak wants to merge 2 commits intoangular:masterfrom
Closed
fix(docs-infra): use .tooltip and highlight the currently active node in top-bar#33351gkalpak wants to merge 2 commits intoangular:masterfrom
.tooltip and highlight the currently active node in top-bar#33351gkalpak wants to merge 2 commits intoangular:masterfrom
Conversation
gkalpak
added
comp: docs-infra
state: blocked
target: patch
|
|
14 tasks
Member
Author
|
The styles might need adjusting once #33255 has been merged. This PR should not be merged before that. |
|
You can preview 1e431f8 at https://pr33351-1e431f8.ngbuilds.io/. |
petebacondarwin
approved these changes
Oct 24, 2019
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM except the styles really do need addressing (as pointed out in the PR description)
The top-menu items have both a `title` and a `tooltip` property. The `title` is used as text content, so there is little point in using it as "tooltip" (via the HTMLElement's `title` property) too. This commit switches to using the `tooltip` property to populate the `title`. Note that in many cases, the `tooltip` property is derived from `title` anyway (so there is no practical change in behavior in these cases).
gkalpak
force-pushed
the
fix-aio-highlight-topbar
branch
from
1e431f8 to
1787155
Compare
|
You can preview 1787155 at https://pr33351-1787155.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-aio-highlight-topbar
branch
from
1787155 to
0ec3ce9
Compare
gkalpak
added
action: merge
Member
Author
|
Rebased on master (now that #33255 has been merged) and marked for merging 🚀 |
mhevery
pushed a commit
that referenced
this pull request
Feb 20, 2020
The top-menu items have both a `title` and a `tooltip` property. The `title` is used as text content, so there is little point in using it as "tooltip" (via the HTMLElement's `title` property) too. This commit switches to using the `tooltip` property to populate the `title`. Note that in many cases, the `tooltip` property is derived from `title` anyway (so there is no practical change in behavior in these cases). PR Close #33351
mhevery
pushed a commit
that referenced
this pull request
Feb 20, 2020
mhevery
pushed a commit
that referenced
this pull request
Feb 20, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to using
NavigationNode#tooltipinaio-top-menuitems and highlights the currently active node in top-bar. See individual commits for more details.Related to #33239 and #33255.