Conversation
IgorMinar
reviewed
Oct 25, 2019
| for (const key in obj) { | ||
| if (obj.hasOwnProperty(key)) { | ||
| let value = obj[key]; | ||
| let value: any = obj[key]; |
Contributor
There was a problem hiding this comment.
maybe add a comment for why the any was introduced and when it can be removed?
In TypeScript 3.7, circularity detection misfires on the declaration of `value` here. microsoft/TypeScript#32950 Declaring an explicit type avoids the problem.
IgorMinar
approved these changes
Oct 31, 2019
IgorMinar
added
target: major
AndrewKushnir
added
target: patch
atscott
pushed a commit
that referenced
this pull request
Nov 1, 2019
In TypeScript 3.7, circularity detection misfires on the declaration of `value` here. microsoft/TypeScript#32950 Declaring an explicit type avoids the problem. PR Close #33294
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TypeScript 3.7, circularity detection misfires on the declaration of
valuehere.microsoft/TypeScript#32950
Declaring an explicit type avoids the problem.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?