Pr 32946 followup#33027
Pr 32946 followup#33027filipesilva wants to merge 3 commits intoangular:masterfrom filipesilva:pr32946
Conversation
BREAKING CHANGE: typescript 3.4 and 3.5 are no longer supported, please update to typescript 3.6 Fixes #32380
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
| } else { | ||
| const moduleInfo = | ||
| ts.resolveModuleName(moduleName, containingFile.fileName, this.compilerHost); | ||
| ts.resolveModuleName(moduleName, containingFile.fileName, this.program.getCompilerOptions(), this.compilerHost); |
There was a problem hiding this comment.
resolveModuleName now takes the compiler options before the ModuleResolutionHost.
| messageText: string; | ||
| position?: Position; | ||
| next?: DiagnosticMessageChain; | ||
| next?: DiagnosticMessageChain[]; |
There was a problem hiding this comment.
ts.DiagnosticMessageChain is now a tree microsoft/TypeScript@ba9d8e2
|
|
||
| const compilerFactory: CompilerFactory = | ||
| defaultPlatform.injector.get(CompilerFactory, null); | ||
| defaultPlatform.injector.get(CompilerFactory, null)!; |
There was a problem hiding this comment.
These could be null, but it seems like they weren't properly detected before. Since this is a spec and it was passing before, it seems ok to add a non-null assertion.
IgorMinar
left a comment
IgorMinar
left a comment
There was a problem hiding this comment.
thanks for the updates
| redirectedReference: ts.ResolvedProjectReference, | ||
| options: ts.CompilerOptions) => (ts.ResolvedModule | undefined)[]; | ||
|
|
||
| >>>>>>> feat: typescript 3.6 support |
| } | ||
|
|
||
| <<<<<<< HEAD | ||
| export enum DirectiveDefFlags { |
There was a problem hiding this comment.
I believe that this is not the right change: DirectiveDefFlags is unused, so my intent was to completely remove it.
|
Moved fixes and comments into #32946 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Followup to #32946