feat: typescript 3.6 support by IgorMinar · Pull Request #32946 · angular/angular

IgorMinar · 2019-10-01T23:46:49Z

BREAKING CHANGE: typescript 3.4 and 3.5 are no longer supported, please update to typescript 3.6

Partly based on #32908 but instead of just making the code compile with 3.6, this PR actually upgrades the typescript version and drops support for tsc 3.4 and 3.5. Due to blocking issues, it might be a good idea to merge #32908 in first, and merge this PR once the blocking issues are resolved.

Currently blocked on:

typescript 3.6.4 release, which should fix Regression: 3.6 crashes if constructor parameters transformed microsoft/TypeScript#33295
- (PR: Handle parentless nodes in isParameterPropertyDeclaration microsoft/TypeScript#33321, merged commit: microsoft/TypeScript@46ccaa2)

TODOs:

uncomment disabled tests from https://github.com/angular/angular/pull/32908/files#diff-264a68237aa09f1a8fb16d5b112053f7

Optional:

tsickle 0.38 release with tsc 3.6 support
- tracking issue: Support TypeScript 3.6 tsickle#1065

mary-poppins · 2019-10-01T23:53:21Z

You can preview 55a03f4 at https://pr32946-55a03f4.ngbuilds.io/.

mary-poppins · 2019-10-02T00:08:55Z

You can preview 10c0e38 at https://pr32946-10c0e38.ngbuilds.io/.

gkalpak · 2019-10-02T08:05:57Z

@IgorMinar, shouldn't this PR be combined with/based on #32908?

gkalpak · 2019-10-02T08:07:33Z

Also, this PR fixes #32380.

lppedd · 2019-10-02T08:27:15Z

Hi! I've noticed the package.json uses 3.6.3. However I encountered this issue when compiling with it in --prod, microsoft/TypeScript#33295, and it is scheduled for 3.6.4. I don't know if the other changes fixed it, just wanted to tell you.

mary-poppins · 2019-10-02T11:50:40Z

You can preview 4852dcc at https://pr32946-4852dcc.ngbuilds.io/.

mary-poppins · 2019-10-02T12:14:13Z

You can preview cb8d778 at https://pr32946-cb8d778.ngbuilds.io/.

IgorMinar · 2019-10-02T12:35:41Z

@lppedd thanks for heads up. I just hit the issue and I'll escalate to the typescript team too cut the 3.6.4 release and publish it on npm.

@gkalpak I think we'll end up merging #32908 before this PR lands - I updated the PR description to clarify the order of events.

filipesilva · 2019-10-07T16:55:48Z

A couple more fixes that were missing are in separate commits in #33027.

googlebot · 2019-10-08T16:11:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

filipesilva · 2019-10-08T16:12:27Z

resolveModuleName now takes the compiler options before the ModuleResolutionHost.

filipesilva · 2019-10-08T16:12:46Z

ts.DiagnosticMessageChain is now a tree microsoft/TypeScript@ba9d8e2

filipesilva · 2019-10-08T16:13:09Z

These could be null, but it seems like they weren't properly detected before. Since this is a spec and it was passing before, it seems ok to add a non-null assertion.

filipesilva · 2019-10-08T16:15:14Z

@googlebot I consent.

googlebot · 2019-10-08T16:15:17Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-10-18T00:03:23Z

You can preview 6737387 at https://pr32946-6737387.ngbuilds.io/.

BREAKING CHANGE: typescript 3.4 and 3.5 are no longer supported, please update to typescript 3.6 Fixes angular#32380

This commit removes `@angular-devkit/build-angular` from package.json for a project that opts into Bazel. This is because the package adds a dependency on node-sass, which is rejected by Bazel due to its absense. This commit also appends to `scripts.postinstall` if it already exists. This is needed because `ng new` in CLI v9 now automatically adds a postinstall step for `ngcc`.

mary-poppins · 2019-10-18T14:13:12Z

You can preview 7f68455 at https://pr32946-7f68455.ngbuilds.io/.

mary-poppins · 2019-10-18T15:28:06Z

You can preview 4596f70 at https://pr32946-4596f70.ngbuilds.io/.

IgorMinar · 2019-10-18T17:13:24Z

merge-assistance: g3 failures are flakes

This commit removes `@angular-devkit/build-angular` from package.json for a project that opts into Bazel. This is because the package adds a dependency on node-sass, which is rejected by Bazel due to its absense. This commit also appends to `scripts.postinstall` if it already exists. This is needed because `ng new` in CLI v9 now automatically adds a postinstall step for `ngcc`. PR Close #32946

PR Close #32946

petebacondarwin · 2019-10-18T17:21:02Z

🎉

Now that angular/angular#32946 has landed, upgrade to ts 3.6.4.

angular-automatic-lock-bot · 2019-11-18T16:11:07Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 1, 2019

IgorMinar force-pushed the build/tsc-3.6 branch from 4852dcc to cb8d778 Compare October 2, 2019 12:07

IgorMinar mentioned this pull request Oct 2, 2019

build: TypeScript 3.6 compatibility. #32908

Closed

filipesilva mentioned this pull request Oct 2, 2019

Ts 3.7-beta support #32962

Closed

14 tasks

atscott added the area: build & ci Related the build and CI infrastructure of the project label Oct 2, 2019

ngbot Bot added this to the needsTriage milestone Oct 2, 2019

IgorMinar force-pushed the build/tsc-3.6 branch 5 times, most recently from 85edd49 to 346c13b Compare October 5, 2019 01:09

filipesilva mentioned this pull request Oct 7, 2019

Pr 32946 followup #33027

Closed

IgorMinar mentioned this pull request Oct 7, 2019

Typescript 3.6.4 not on npm microsoft/TypeScript#33854

Closed

googlebot added cla: no and removed cla: yes labels Oct 8, 2019

filipesilva reviewed Oct 8, 2019

View reviewed changes

IgorMinar force-pushed the build/tsc-3.6 branch from b530dc4 to 6737387 Compare October 17, 2019 23:55

filipesilva mentioned this pull request Oct 18, 2019

feat(core): add TS migration #33250

Closed

14 tasks

IgorMinar force-pushed the build/tsc-3.6 branch from 6737387 to c760a1d Compare October 18, 2019 14:04

IgorMinar and others added 4 commits October 18, 2019 07:04

feat: typescript 3.6 support

0318d62

BREAKING CHANGE: typescript 3.4 and 3.5 are no longer supported, please update to typescript 3.6 Fixes angular#32380

test: use @types/node compatible with TS 3.6

22085b6

fixup! feat: typescript 3.6 support

7f68455

IgorMinar force-pushed the build/tsc-3.6 branch from c760a1d to 7f68455 Compare October 18, 2019 14:05

fixup! feat: typescript 3.6 support

4596f70

matsko closed this in 86e1e6c Oct 18, 2019

matsko pushed a commit that referenced this pull request Oct 18, 2019

test: use @types/node compatible with TS 3.6 (#32946)

a0d16dc

PR Close #32946

kyliau pushed a commit to kyliau/vscode-ng-language-service that referenced this pull request Oct 18, 2019

build: upgrade to TypeScript 3.6.4

a54642e

Now that angular/angular#32946 has landed, upgrade to ts 3.6.4.

kyliau mentioned this pull request Oct 18, 2019

build: upgrade to TypeScript 3.6.4 angular/vscode-ng-language-service#424

Merged

kyliau pushed a commit to kyliau/vscode-ng-language-service that referenced this pull request Oct 18, 2019

build: upgrade to TypeScript 3.6.4

cd91922

Now that angular/angular#32946 has landed, upgrade to ts 3.6.4.

kyliau pushed a commit to kyliau/vscode-ng-language-service that referenced this pull request Oct 18, 2019

build: upgrade to TypeScript 3.6.4

3edae4f

Now that angular/angular#32946 has landed, upgrade to ts 3.6.4.

ayazhafiz pushed a commit to angular/vscode-ng-language-service that referenced this pull request Oct 18, 2019

build: upgrade to TypeScript 3.6.4 (#424)

cf0a0b9

Now that angular/angular#32946 has landed, upgrade to ts 3.6.4.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 18, 2019

Conversation

IgorMinar commented Oct 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Oct 1, 2019

Uh oh!

mary-poppins commented Oct 2, 2019

Uh oh!

gkalpak commented Oct 2, 2019

Uh oh!

gkalpak commented Oct 2, 2019

Uh oh!

lppedd commented Oct 2, 2019

Uh oh!

mary-poppins commented Oct 2, 2019

Uh oh!

mary-poppins commented Oct 2, 2019

Uh oh!

IgorMinar commented Oct 2, 2019

Uh oh!

filipesilva commented Oct 7, 2019

Uh oh!

googlebot commented Oct 8, 2019

Uh oh!

filipesilva Oct 8, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Oct 8, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Oct 8, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva commented Oct 8, 2019

Uh oh!

googlebot commented Oct 8, 2019

Uh oh!

mary-poppins commented Oct 18, 2019

Uh oh!

mary-poppins commented Oct 18, 2019

Uh oh!

mary-poppins commented Oct 18, 2019

Uh oh!

IgorMinar commented Oct 18, 2019

Uh oh!

petebacondarwin commented Oct 18, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

IgorMinar commented Oct 1, 2019 •

edited

Loading