Skip to content

fix(zone.js): should expose some other internal intefaces#31866

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-patch-fn
Closed

fix(zone.js): should expose some other internal intefaces#31866
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-patch-fn

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Jul 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A
zone.js.d.ts now expose __load_patch(name: string, fn: _PatchFn), but _PatchFn is not exposed.

What is the new behavior?

expose _PatchFn , _ZonePrivate and _ZoneFrame interface.

Does this PR introduce a breaking change?

  • Yes
  • No

@JiaLiPassion JiaLiPassion requested review from a team and mhevery July 26, 2019 22:09
@JiaLiPassion JiaLiPassion added the area: zones Issues related to zone.js label Jul 26, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jul 26, 2019
@mhevery mhevery added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jul 26, 2019
@mhevery mhevery self-assigned this Jul 26, 2019
@vladimiry
Copy link
Copy Markdown

vladimiry commented Jul 28, 2019

Thanks for a fast fix.

The error to be fixed (skipLibCheck compilation option is a workaround):

node_modules/zone.js/dist/zone.js.d.ts:292:36 - error TS2304: Cannot find name '_PatchFn'.

292     __load_patch(name: string, fn: _PatchFn): void;

AndrewKushnir pushed a commit that referenced this pull request Jul 29, 2019
@JiaLiPassion @AndrewKushnir
fix(zone.js): should expose some other internal intefaces (#31866)
d269b11 
PR Close #31866
@vladimiry vladimiry mentioned this pull request Jul 30, 2019
Closed
@weswigham weswigham mentioned this pull request Aug 1, 2019
Merged
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
fix(zone.js): should expose some other internal intefaces (angular#31866
1dae217 
)

PR Close angular#31866
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@JiaLiPassion @vladimiry @mhevery @googlebot