Skip to content

feat(zone.js): support Promise.allSettled#31849

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:promise-allsettled
Closed

feat(zone.js): support Promise.allSettled#31849
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:promise-allsettled

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Jul 25, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Since Promise.allSettled become stage 4, I added this API in ZoneAwarePromise.

Does this PR introduce a breaking change?

  • Yes
  • No

@JiaLiPassion JiaLiPassion requested a review from a team July 25, 2019 22:28
@JiaLiPassion JiaLiPassion requested a review from mhevery July 25, 2019 22:28
@ngbot ngbot Bot added this to the needsTriage milestone Jul 25, 2019
@kapunahelewong kapunahelewong added effort1: hours risk: low feature Label used to distinguish feature request from other issues labels Jul 26, 2019
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Jul 26, 2019
@kapunahelewong kapunahelewong added state: needs eng review Needs technical review and approval from engineering team and removed state: needs eng review Needs technical review and approval from engineering team labels Jul 26, 2019
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Jul 26, 2019

http://test/OCL:260174045:BASE:260174071:1564163695823:a27e9cdf

@mhevery mhevery self-assigned this Jul 26, 2019
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2019
@alxhub alxhub added the target: major This PR is targeted for the next major release label Aug 2, 2019
@alxhub alxhub closed this in 96cbcd6 Aug 5, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
feat(zone.js): support Promise.allSettled (angular#31849)
8d56764 
PR Close angular#31849
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Label used to distinguish feature request from other issues risk: low target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@JiaLiPassion @mhevery @kapunahelewong @alxhub @googlebot @jbogarthyde