fix(zone.js): don't rely on global node typings outside of node/ dire…#31783
fix(zone.js): don't rely on global node typings outside of node/ dire…#31783alexeagle wants to merge 1 commit intoangular:masterfrom
Conversation
alexeagle
force-pushed
the
zone_sync
branch
2 times, most recently
from
19dfca7 to
4f66c64
Compare
|
Note: this is required to switch google3 to point at this new location of zone.js sources |
There was a problem hiding this comment.
it seems there is an additional space at the end of this comment which will fail the tslint.
There was a problem hiding this comment.
got it, there is a reference to node declaration here https://github.com/angular/angular/blob/master/packages/zone.js/lib/common/utils.ts#L14, should we also remove that?
There was a problem hiding this comment.
No we don't need to - that isn't on the critical path to fix the compilation in g3. We could do more changes later...
| // This code should run in a Browser, so we don't want to include the whole node.d.ts | ||
| // typings for this compilation unit. | ||
| // We'll just fake the global "global" var for now. | ||
| declare var global: NodeJS.Global; |
There was a problem hiding this comment.
note, in g3 there is a transformation to replace NodeJS.Global with {} since this file is compiled without node typings in g3
alexeagle
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
…ctory