Skip to content

fix(zone.js): Closes #31701, don't fire unhandledrejection if Zone handled error#31718

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:bluebird-error
Closed

fix(zone.js): Closes #31701, don't fire unhandledrejection if Zone handled error#31718
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:bluebird-error

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Jul 21, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31701
If zone onHandleError handled error and return false, should not fire unhandledrejection to bluebird

What is the new behavior?

If zone onHandleError handled error and return false, will not fire unhandledrejection to bluebird

Does this PR introduce a breaking change?

  • Yes
  • No

@JiaLiPassion JiaLiPassion requested a review from a team July 21, 2019 10:51
@mhevery mhevery added the target: patch This PR is targeted for the next patch release label Jul 22, 2019
@mhevery mhevery added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker and removed target: major This PR is targeted for the next major release labels Jul 22, 2019
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Jul 22, 2019

http://test/OCL:259420987:BASE:259421006:1563835106863:c38363d1

mhevery pushed a commit that referenced this pull request Jul 24, 2019
@JiaLiPassion @mhevery
fix(zone.js): don't fire unhandledrejection if Zone handled error (#3…
fdf2f69 
…1718)

Close #31701

PR Close #31718
@mhevery mhevery closed this in c7542a1 Jul 24, 2019
@fxck
Copy link
Copy Markdown

fxck commented Jul 25, 2019

This should fix Enngage/ngx-captcha#35 and DethAriel/ng-recaptcha#123 as well, right?

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
fix(zone.js): don't fire unhandledrejection if Zone handled error (an…
a1398be 
…gular#31718)

Close angular#31701

PR Close angular#31718
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JiaLiPassion @mhevery @fxck @googlebot