fix(zone.js): Closes #31659, move property patch to legacy#31660
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): Closes #31659, move property patch to legacy#31660JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
force-pushed
the
property-patch
branch
from
f8e4e10 to
2ac3716
Compare
mhevery
approved these changes
Jul 22, 2019
mhevery
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Jul 24, 2019
JiaLiPassion
added a commit
to JiaLiPassion/angular
that referenced
this pull request
Aug 16, 2019
Bundle size changed in both zone.js(legacy) and zone-evergreen.js - zone.js(legacy) package increased a little because the following feature and fixes. 1. angular#31699, handle MSPointer events PR 2. angular/zone.js#1219 to add __zone_symbol__ customization support - zone-evergreen.js package decreased because 1. the MSPointer PR only for legacy 2. the Object.defineProperty patch is moved to legacy angular#31660
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 16, 2019
Bundle size changed in both zone.js(legacy) and zone-evergreen.js - zone.js(legacy) package increased a little because the following feature and fixes. 1. #31699, handle MSPointer events PR 2. angular/zone.js#1219 to add __zone_symbol__ customization support - zone-evergreen.js package decreased because 1. the MSPointer PR only for legacy 2. the Object.defineProperty patch is moved to legacy #31660 PR Close #31975
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Bundle size changed in both zone.js(legacy) and zone-evergreen.js - zone.js(legacy) package increased a little because the following feature and fixes. 1. angular#31699, handle MSPointer events PR 2. angular/zone.js#1219 to add __zone_symbol__ customization support - zone-evergreen.js package decreased because 1. the MSPointer PR only for legacy 2. the Object.defineProperty patch is moved to legacy angular#31660 PR Close angular#31975
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #31659
In some browser, monkey-patch
Object.definePropertywill cause some errors. This patch suppose to resolve some very old browsers (android 4?) issues, so it should be moved to legacy.What is the new behavior?
move property patch(
Object.defineProperty) to legacyDoes this PR introduce a breaking change?