fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler#31350
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler#31350JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
changed the title
mhevery
approved these changes
Jul 12, 2019
mhevery
added
the
action: cleanup
…r closure compiler
JiaLiPassion
force-pushed
the
zone-extern
branch
from
6f744e2 to
020a748
Compare
JiaLiPassion
removed
the
action: cleanup
mhevery
approved these changes
Jul 22, 2019
Contributor
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…r closure compiler (angular#31350) PR Close angular#31350
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #30533
If we use
Zone.__symbol__in application or angular code, after closure compiler, the__symbol__will be gone, because this API is internal and not exist in extern declaration filezone_extern.js. We need to add those APIs (symbol and __load_patch) because they are also public APIs.What is the new behavior?
__symbol__ and __load_patchbecomes public APIs.Does this PR introduce a breaking change?
#30533 need this PR to work.