fix(router): change undefined route snapshot fragment to null#29819
Closed
ArtificialQualia wants to merge 4 commits intoangular:masterfrom
Closed
fix(router): change undefined route snapshot fragment to null#29819ArtificialQualia wants to merge 4 commits intoangular:masterfrom
ArtificialQualia wants to merge 4 commits intoangular:masterfrom
Conversation
When going to a link through the router, the fragment would be undefined. However on a page refresh, it would become null. Now the fragment is null in both cases. PR Close angular#29391
Contributor
|
Superseded by #37336. |
14 tasks
Contributor
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #29391
What is the new behavior?
If fragment is not set, it is always null. Not sometimes null and sometimes undefined.
Does this PR introduce a breaking change?
Other information