Skip to content

docs: update Universal guide#28956

Closed
CaerusKaru wants to merge 3 commits intoangular:masterfrom
CaerusKaru:adam/universal-docs
Closed

docs: update Universal guide#28956
CaerusKaru wants to merge 3 commits intoangular:masterfrom
CaerusKaru:adam/universal-docs

Conversation

@CaerusKaru
Copy link
Copy Markdown
Member

@CaerusKaru CaerusKaru commented Feb 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru CaerusKaru requested a review from a team February 24, 2019 23:55
@alan-agius4
Copy link
Copy Markdown
Contributor

alan-agius4 commented Feb 25, 2019

Maybe we can combine this with #28231?

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 25, 2019

You can preview e6cf904 at https://pr28956-e6cf904.ngbuilds.io/.

@brandonroberts brandonroberts added comp: docs effort2: days refactoring Issue that involves refactoring or code-cleanup area: server Issues related to server-side rendering risk: medium labels Feb 25, 2019
@ngbot ngbot Bot added this to the Backlog milestone Feb 25, 2019
@brandonroberts brandonroberts added the target: patch This PR is targeted for the next patch release label Feb 25, 2019
@CaerusKaru
Copy link
Copy Markdown
Member Author

CaerusKaru commented Feb 26, 2019

@alan-agius4 I made these edits with your PR in mind, I'm hoping that it at least mostly matches up with the changes you made? If there's something specific you'd like me to port over, please let me know.

I was hoping your PR was going to be merged by now, but it looks like it got stalled.

jbogarthyde
jbogarthyde reviewed Mar 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy edit

Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
jbogarthyde
jbogarthyde reviewed Mar 4, 2019
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
vikerman
vikerman suggested changes Mar 5, 2019
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
@CaerusKaru CaerusKaru force-pushed the adam/universal-docs branch from e6cf904 to 6f79659 Compare March 6, 2019 03:38
@CaerusKaru
Copy link
Copy Markdown
Member Author

CaerusKaru commented Mar 6, 2019

@jbogarthyde @vikerman Feedback addressed 👍

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 6, 2019

You can preview 6f79659 at https://pr28956-6f79659.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 7, 2019

You can preview ec3dd78 at https://pr28956-ec3dd78.ngbuilds.io/.

@benlesh benlesh added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Mar 11, 2019
@kara
Copy link
Copy Markdown
Contributor

kara commented Mar 11, 2019

@jbogarthyde Does this have approval from docs team?

@kara kara removed the action: merge The PR is ready for merge by the caretaker label Mar 11, 2019
@kara kara added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 11, 2019
@jbogarthyde
Copy link
Copy Markdown
Contributor

jbogarthyde commented Mar 11, 2019

It does if I have the right to approve it.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 11, 2019
@kara kara closed this in ed4675e Mar 11, 2019
kara pushed a commit that referenced this pull request Mar 11, 2019
@CaerusKaru @kara
docs: update Universal guide (#28956)
1c838eb 
PR Close #28956
@CaerusKaru CaerusKaru deleted the adam/universal-docs branch March 11, 2019 23:49
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@CaerusKaru @wKoza
docs: update Universal guide (angular#28956)
0edde7e 
PR Close angular#28956
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jbogarthyde jbogarthyde jbogarthyde left review comments

@vikerman vikerman vikerman approved these changes

@MarkPieszak MarkPieszak MarkPieszak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering cla: yes effort2: days refactoring Issue that involves refactoring or code-cleanup risk: medium target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

10 participants

@CaerusKaru @alan-agius4 @mary-poppins @kara @jbogarthyde @vikerman @MarkPieszak @brandonroberts @benlesh @googlebot