Skip to content

docs: update universal guide to use ng add#28231

Closed
alan-agius4 wants to merge 2 commits intoangular:masterfrom
alan-agius4:universal-ng-add
Closed

docs: update universal guide to use ng add#28231
alan-agius4 wants to merge 2 commits intoangular:masterfrom
alan-agius4:universal-ng-add

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 commented Jan 18, 2019

This changes the universal guide to use ng add

Fixes #28158

//cc @IgorMinar & @jenniferfell

Can someone also kindly add aio-preview label. Thanks

@alan-agius4 alan-agius4 requested a review from a team January 18, 2019 12:28
@vikerman vikerman self-assigned this Jan 18, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 23, 2019
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 24, 2019

You can preview 83f4770 at https://pr28231-83f4770.ngbuilds.io/.
You can preview 5b60bad at https://pr28231-5b60bad.ngbuilds.io/.

@jenniferfell jenniferfell added the area: server Issues related to server-side rendering label Jan 25, 2019
jbogarthyde
jbogarthyde suggested changes Jan 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a section on using ng generate app-shell?

Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
@jbogarthyde jbogarthyde mentioned this pull request Jan 25, 2019
Closed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Jan 26, 2019 •
edited
Loading

@jbogarthyde, I fixed the grammer related issues.

I'll try to find some time to add the app-shell section in the coming days.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 26, 2019

You can preview 284b852 at https://pr28231-284b852.ngbuilds.io/.

@brandonroberts brandonroberts added feature Label used to distinguish feature request from other issues effort2: days risk: medium labels Jan 29, 2019
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Jan 29, 2019
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 4, 2019

You can preview 8bcd144 at https://pr28231-8bcd144.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 4, 2019

You can preview 7e63d78 at https://pr28231-7e63d78.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 4, 2019

You can preview d9558ce at https://pr28231-d9558ce.ngbuilds.io/.

jbogarthyde
jbogarthyde reviewed Feb 4, 2019
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
Comment thread aio/content/guide/universal.md Outdated
jbogarthyde
jbogarthyde reviewed Feb 5, 2019
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
jbogarthyde
jbogarthyde reviewed Feb 5, 2019
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 5, 2019

You can preview 161b096 at https://pr28231-161b096.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 7, 2019

You can preview ee48d64 at https://pr28231-ee48d64.ngbuilds.io/.

@alan-agius4 alan-agius4 mentioned this pull request Feb 11, 2019
Closed
12 tasks
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Feb 11, 2019

@jbogarthyde, changes done.

@alan-agius4 alan-agius4 mentioned this pull request Feb 25, 2019
Closed
14 tasks
@jbogarthyde jbogarthyde added the target: patch This PR is targeted for the next patch release label Feb 25, 2019
@alan-agius4 alan-agius4 requested a review from vikerman March 6, 2019 19:36
@brandonroberts
Copy link
Copy Markdown
Contributor

brandonroberts commented Mar 15, 2019

@alan-agius4 ok to close due to the rewrite of the guide?

@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Mar 15, 2019

Yes

@alan-agius4 alan-agius4 deleted the universal-ng-add branch March 15, 2019 14:31
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vikerman vikerman Awaiting requested review from vikerman

2 more reviewers

@MarkPieszak MarkPieszak MarkPieszak approved these changes

@jbogarthyde jbogarthyde jbogarthyde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikerman vikerman

Labels

area: server Issues related to server-side rendering cla: yes effort2: days feature Label used to distinguish feature request from other issues risk: medium target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Update universal guide to use ng add

9 participants

@alan-agius4 @mary-poppins @brandonroberts @MarkPieszak @jbogarthyde @vikerman @jasonaden @googlebot @jenniferfell