Skip to content

docs: update universal documentation as per starter#26444

Closed
alan-agius4 wants to merge 1 commit intoangular:masterfrom
alan-agius4:docs_universal
Closed

docs: update universal documentation as per starter#26444
alan-agius4 wants to merge 1 commit intoangular:masterfrom
alan-agius4:docs_universal

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 commented Oct 15, 2018 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

At the moment the docs here do not reflect the starter kit in https://github.com/angular/universal-starter

What is the new behavior?

This PR aligns them.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

//cc @jenniferfell & @CaerusKaru

Follow up of #25752

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 16, 2018

You can preview 774835e at https://pr26444-774835e.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 16, 2018

You can preview 4dec587 at https://pr26444-4dec587.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 17, 2018

You can preview 28a0d15 at https://pr26444-28a0d15.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 17, 2018

You can preview 1506a41 at https://pr26444-1506a41.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 18, 2018

You can preview 71dcc89 at https://pr26444-71dcc89.ngbuilds.io/.

@brandonroberts brandonroberts added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours refactoring Issue that involves refactoring or code-cleanup freq1: low area: server Issues related to server-side rendering target: patch This PR is targeted for the next patch release labels Oct 18, 2018
@ngbot ngbot Bot added this to the needsTriage milestone Oct 18, 2018
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Oct 18, 2018
@thanhpd thanhpd mentioned this pull request Oct 25, 2018
Closed
3 tasks
@brandonroberts brandonroberts self-assigned this Oct 29, 2018
@brandonroberts
Copy link
Copy Markdown
Contributor

brandonroberts commented Oct 29, 2018

@alan-agius4 will you rebase this on master?

@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Oct 29, 2018

rebase done

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 29, 2018

You can preview bcbba63 at https://pr26444-bcbba63.ngbuilds.io/.

brandonroberts
brandonroberts suggested changes Oct 29, 2018
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
Copy link
Copy Markdown
Contributor

@brandonroberts brandonroberts Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using lazy loaded modules together with an app shell, you ...

Copy link
Copy Markdown
Contributor Author

@alan-agius4 alan-agius4 Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment thread aio/content/guide/universal.md Outdated
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 29, 2018

You can preview 63e5f7a at https://pr26444-63e5f7a.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 29, 2018

You can preview afe4962 at https://pr26444-afe4962.ngbuilds.io/.

@jbogarthyde
Copy link
Copy Markdown
Contributor

jbogarthyde commented Oct 29, 2018

LGTM --jb

@brandonroberts
Copy link
Copy Markdown
Contributor

brandonroberts commented Oct 29, 2018

@alan-agius4 the example dependencies need to be updated also. The ts-loader and webpack-cli dependencies should be removed from https://github.com/angular/angular/blob/master/aio/tools/examples/shared/package.json and https://github.com/angular/angular/blob/master/aio/tools/examples/shared/boilerplate/universal/package.json

You'll also need to run yarn in the aio/tools/examples/shared folder to update the yarn.lock file.

@alan-agius4 alan-agius4 mentioned this pull request Oct 29, 2018
Closed
@brandonroberts
Copy link
Copy Markdown
Contributor

brandonroberts commented Nov 15, 2018

@IgorMinar will you review/approve this so it can land?

DaSchTour
DaSchTour reviewed Dec 4, 2018
View reviewed changes
Comment thread aio/content/guide/universal.md Outdated
This was referenced Dec 28, 2018
Closed
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 3, 2019

You can preview eed1a1a at https://pr26444-eed1a1a.ngbuilds.io/.

@alan-agius4 alan-agius4 mentioned this pull request Jan 9, 2019
Closed
IgorMinar
IgorMinar approved these changes Jan 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except that now that we had ng add shouldn’t this guide use that instead of manual setup?

I think it’s fine to merge this as is, but we should follow up with refactoring this doc to rely on ng add.

@alan-agius4 can you please rebase this on top of master before labeling this for merge? Thanks

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2019
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Jan 11, 2019

@IgorMinar, rebased

Yeah, indeed as as there is also a bit of confusion as in the CLI itself we have ng generate universal, which is a subset of what ng add does.

I'll open an issue tomorrow to keep track of it.

PS: I cannot change labels on angular/angular, I don't have access :(

@alan-agius4 alan-agius4 requested a review from a team January 11, 2019 20:37
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 11, 2019

You can preview 01303d3 at https://pr26444-01303d3.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 12, 2019
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jan 12, 2019 •
edited
Loading

Marking it for merge based on the conversation above.

@brandonroberts brandonroberts removed the request for review from jenniferfell January 14, 2019 13:45
@brandonroberts brandonroberts mentioned this pull request Jan 14, 2019
Closed
14 tasks
AndrewKushnir pushed a commit that referenced this pull request Jan 14, 2019
@alan-agius4 @AndrewKushnir
docs: fix scripts section and some minor issues in universal document…
f810180 
…ation (#26444)

PR Close #26444
@alan-agius4 alan-agius4 deleted the docs_universal branch January 14, 2019 18:18
@brandonroberts brandonroberts mentioned this pull request Jan 15, 2019
Closed
14 tasks
@alan-agius4 alan-agius4 mentioned this pull request Jan 15, 2019
Closed
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@alan-agius4 @AndrewKushnir
docs: fix scripts section and some minor issues in universal document…
b9fd624 
…ation (#26444)

PR Close #26444
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@DaSchTour DaSchTour DaSchTour left review comments

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brandonroberts brandonroberts

@IgorMinar IgorMinar

Labels

action: discuss action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering cla: yes effort1: hours freq1: low refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

10 participants

@alan-agius4 @mary-poppins @brandonroberts @jbogarthyde @CaerusKaru @gkalpak @IgorMinar @DaSchTour @vikerman @googlebot