build: upgrade zone.js#23108
Conversation
1e57798 to
2f60702
Compare
mhevery
left a comment
There was a problem hiding this comment.
There seem to be a lot of unrelated formatting changes in the source code. Could you revert those?
Thank you for looking into this.
There was a problem hiding this comment.
should this file be reverted?
edebbe2 to
d7fd35f
Compare
IgorMinar
left a comment
There was a problem hiding this comment.
Is this a breaking change in zone.js that should be documented and require a minor version bump?
In other words do we expect others to have to make these changes as well? Should we update our testing docs?
|
@IgorMinar , I will update the test document now, about the break change such as user don't need to write |
af65100 to
b6c63cc
Compare
There was a problem hiding this comment.
Shouldn't this be replaced to point to an npm release?
There was a problem hiding this comment.
@gkalpak , sure, if the g3 test passed, zone.js will have a new release
There was a problem hiding this comment.
Shouldn't this be replaced to point to an npm release?
|
Removed the |
|
Hi @JiaLiPassion! This PR has merge conflicts due to recent upstream merges. |
439eb99 to
eea5c5b
Compare
|
🎉 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
based on #23100
Upgrade
zone.jsto latest version, currently this PR is just for test, because it depends on myzone.js branch.in
zone.js0.8.21, there are several feature which breakangulartest.async/fakeAsyncfrom angular to zone.jsjasmine.clock()to be auto jump intofakeAsyncthis feature break the test cases in
aio. https://github.com/angular/angular/blob/master/aio/src/app/app.component.spec.ts#L1110which use
jasmine.clock()to simulatetimer, but still useasync/await, so it will beTIMEOUT, in this PR, just removeasync/awaitand usetick.angularwill be timeout, https://travis-ci.org/angular/angular/jobs/360448001the reason is because
zone.js AsyncTestZoneSpecadd a new feature to be able to waitnon resolved promise.then, it seems this feature will have a big impact to currentangulartest cases, for example, in the following case,https://github.com/angular/angular/blob/master/packages/compiler/test/metadata_resolver_spec.ts#L87
current test case seems have some error, that the
promise.thennever invoked, but in earlier version ofzone.js, this test case will pass, but inzone.js 0.8.21, this will fail. there are several similar cases, so I just disable this feature in fix(fakeAsync): fix #1050, should only reset patched Date.now until fakeAsync exit zone.js#1051, and I will check all related test cases in angular later.