Skip to content

feat: add support for the safe navigation (aka Elvis) operator#2152

Merged
vicb merged 1 commit intoangular:masterfrom
vicb:0521-elvis
May 28, 2015
Merged

feat: add support for the safe navigation (aka Elvis) operator#2152
vicb merged 1 commit intoangular:masterfrom
vicb:0521-elvis

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented May 26, 2015

fixes #791

@vicb vicb added feature Label used to distinguish feature request from other issues #change_detection labels May 26, 2015
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented May 26, 2015

@kegluneq depending on which of your Dart PR or this one will get merged first, one of us will have to update the Dart JIT code to add safe methods.

@vicb vicb force-pushed the 0521-elvis branch 3 times, most recently from 13849cc to 34d97c9 Compare May 26, 2015 12:30
@kegluneq
Copy link
Copy Markdown

kegluneq commented May 26, 2015

Thanks for the heads up -- we'll have to update the Js JIT code also, which is modified a decent bit in my PR.

IgorMinar
IgorMinar reviewed May 26, 2015
View reviewed changes
modules/angular2/src/change_detection/parser/lexer.ts Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you just let it fall through and let $CARET handle it?

Copy link
Copy Markdown
Contributor Author

@vicb vicb May 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll update

IgorMinar
IgorMinar reviewed May 27, 2015
View reviewed changes
modules/angular2/test/change_detection/parser/lexer_spec.js Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar May 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are unrelated to the intent of this PR. next time please create a separate commit for style fixes

Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar May 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason being that you are bloating up the PR and in the future when someone is looking at blame log for a file they'll see a lot of unrelated noise.

@vsavkin vsavkin added @lgtm action: merge The PR is ready for merge by the caretaker labels May 27, 2015
@vicb vicb force-pushed the 0521-elvis branch 3 times, most recently from 500df13 to e488335 Compare May 28, 2015 20:55
@vicb vicb merged commit a9be2eb into angular:master May 28, 2015
@vicb vicb removed the in progress label May 28, 2015
@vicb vicb deleted the 0521-elvis branch June 10, 2015 12:37
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes feature Label used to distinguish feature request from other issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Elvis operator in expressions: ?.

5 participants

@vicb @kegluneq @IgorMinar @vsavkin @googlebot