Skip to content

Restore animation child leave commits#19693

Closed
matsko wants to merge 2 commits intoangular:masterfrom
matsko:restore_animation_child_leave_commits
Closed

Restore animation child leave commits#19693
matsko wants to merge 2 commits intoangular:masterfrom
matsko:restore_animation_child_leave_commits

Conversation

@matsko
Copy link
Copy Markdown
Contributor

@matsko matsko commented Oct 12, 2017

No description provided.

@mary-poppins
Copy link
Copy Markdown

@matsko matsko added the target: major This PR is targeted for the next major release label Oct 16, 2017
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2017
@tbosch tbosch closed this in f42d317 Oct 16, 2017
tbosch pushed a commit that referenced this pull request Oct 16, 2017
@IgorMinar
Copy link
Copy Markdown
Contributor

@tbosch @matsko this PR is missing approval. Can you please ensure that all future PRs have an approval? thanks

@IgorMinar
Copy link
Copy Markdown
Contributor

I'm assuming that either one of you reviewed this since you applied the labels.

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Oct 18, 2017

@IgorMinar These are just roll forwards of ac50bd6 and 9130505.

But yes, I should have added the approval.

@tbosch tbosch self-requested a review October 18, 2017 00:43
Copy link
Copy Markdown
Contributor

@tbosch tbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just roll forwards of ac50bd6 and 9130505.

@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Oct 18, 2017 via email

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants