Skip to content

fix(animations): ensure animateChild() works with all inner leave animations#19532

Closed
matsko wants to merge 2 commits intoangular:masterfrom
matsko:inner_leave_animations_part_2
Closed

fix(animations): ensure animateChild() works with all inner leave animations#19532
matsko wants to merge 2 commits intoangular:masterfrom
matsko:inner_leave_animations_part_2

Conversation

@matsko
Copy link
Copy Markdown
Contributor

@matsko matsko commented Oct 3, 2017

Closes #18305

@matsko matsko force-pushed the inner_leave_animations_part_2 branch from aa36f99 to e92f3ff Compare October 3, 2017 18:36
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 3, 2017

You can preview e92f3ff at https://pr19532-e92f3ff.ngbuilds.io/.

@matsko matsko force-pushed the inner_leave_animations_part_2 branch 3 times, most recently from 4a89ecc to 3ab4357 Compare October 4, 2017 23:52
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 4, 2017

You can preview 72e3ae2 at https://pr19532-72e3ae2.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 4, 2017

You can preview 4a89ecc at https://pr19532-4a89ecc.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 5, 2017

You can preview 3ab4357 at https://pr19532-3ab4357.ngbuilds.io/.

@matsko
Copy link
Copy Markdown
Contributor Author

matsko commented Oct 5, 2017

This passes on TAP

@matsko matsko requested a review from mhevery October 5, 2017 21:26
@matsko matsko force-pushed the inner_leave_animations_part_2 branch from 3ab4357 to 0430851 Compare October 5, 2017 21:28
@matsko matsko added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release labels Oct 5, 2017
@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2017
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 5, 2017

You can preview 0430851 at https://pr19532-0430851.ngbuilds.io/.

@tbosch tbosch modified the milestone: Merge-queue Oct 6, 2017
chuckjaz pushed a commit to chuckjaz/angular that referenced this pull request Oct 6, 2017
@matsko @chuckjaz
fix(animations): ensure animateChild() works with all inner leave ani…
1c77cda 
…mations (angular#19532)

Closes angular#18305

PR Close angular#19532
@chuckjaz chuckjaz closed this in f12e15e Oct 6, 2017
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Oct 7, 2017
@chuckjaz
Revert "fix(animations): ensure animateChild() works with all inner l…
f4480d4 
…eave animations (angular#19532)"

This reverts commit 1c77cda.
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Oct 7, 2017
@chuckjaz
Revert "test(animations): test to see if triggers get cancelled on re…
9fecd72 
…moval (angular#19532)"

This reverts commit f12e15e.
@chuckjaz chuckjaz reopened this Oct 9, 2017
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 9, 2017

You can preview 0430851 at https://pr19532-0430851.ngbuilds.io/.

@matsko matsko force-pushed the inner_leave_animations_part_2 branch from 0430851 to 80a1ef1 Compare October 9, 2017 18:32
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 9, 2017

You can preview 80a1ef1 at https://pr19532-80a1ef1.ngbuilds.io/.

@matsko matsko force-pushed the inner_leave_animations_part_2 branch from 80a1ef1 to 65abdf9 Compare October 9, 2017 20:06
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 9, 2017

You can preview 65abdf9 at https://pr19532-65abdf9.ngbuilds.io/.

@matsko matsko force-pushed the inner_leave_animations_part_2 branch from 65abdf9 to 55b0d86 Compare October 9, 2017 21:30
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 9, 2017

You can preview 55b0d86 at https://pr19532-55b0d86.ngbuilds.io/.

chuckjaz pushed a commit to chuckjaz/angular that referenced this pull request Oct 10, 2017
@matsko @chuckjaz
fix(animations): ensure inner :leave animations do not remove node wh…
ac50bd6 
…en skipped (angular#19532)

PR Close angular#19532
@chuckjaz chuckjaz closed this in 9130505 Oct 10, 2017
@dharders dharders mentioned this pull request Oct 10, 2017
Closed
chuckjaz added a commit that referenced this pull request Oct 11, 2017
@chuckjaz
Revert "fix(animations): ensure inner :leave animations do not remove…
d0af45c 
… node when skipped (#19532)"

This reverts commit ac50bd6.
chuckjaz added a commit that referenced this pull request Oct 11, 2017
@chuckjaz
Revert "fix(animations): ensure animateChild() works with all inner l…
46992b4 
…eave animations (#19006) (#19532)"

This reverts commit 9130505.
matsko added a commit to matsko/angular that referenced this pull request Oct 12, 2017
@matsko
fix(animations): ensure animateChild() works with all inner leave ani…
e08bfbd 
…mations (angular#19006) (angular#19532)
matsko added a commit to matsko/angular that referenced this pull request Oct 12, 2017
@matsko
fix(animations): ensure inner :leave animations do not remove node wh…
1fc1082 
…en skipped (angular#19532)
tbosch pushed a commit that referenced this pull request Oct 16, 2017
@matsko @tbosch
fix(animations): ensure animateChild() works with all inner leave ani…
f42d317 
…mations (#19006) (#19532) (#19693)

PR Close #19693
tbosch pushed a commit that referenced this pull request Oct 16, 2017
@matsko @tbosch
fix(animations): ensure inner :leave animations do not remove node wh…
d035175 
…en skipped (#19532) (#19693)

PR Close #19693
@avbentem avbentem mentioned this pull request Nov 20, 2017
Closed
@matsko matsko deleted the inner_leave_animations_part_2 branch January 17, 2019 19:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mhevery mhevery mhevery approved these changes

@chuckjaz chuckjaz chuckjaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Merge-queue

Development

Successfully merging this pull request may close these issues.

Animations: animateChild() not working correctly

6 participants

@matsko @mary-poppins @mhevery @chuckjaz @tbosch @googlebot