Skip to content

build(aio): use cli 1.3.0-rc#18290

Merged
vicb merged 1 commit intoangular:masterfrom
filipesilva:use-cli-rc
Aug 2, 2017
Merged

build(aio): use cli 1.3.0-rc#18290
vicb merged 1 commit intoangular:masterfrom
filipesilva:use-cli-rc

Conversation

@filipesilva
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva commented Jul 22, 2017 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

AIO was using a modified version of Angular CLI, patched to include new features. These features have now been incorporated into Angular CLI so it can be used directly instead.

What is the new behavior?

AIO uses the official Angular CLI with no custom patches.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

/cc @IgorMinar

Other information

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 22, 2017

You can preview d039c8e at https://pr18290-d039c8e.ngbuilds.io/.

@mhevery mhevery added the area: build & ci Related the build and CI infrastructure of the project label Jul 26, 2017
@mhevery mhevery requested a review from IgorMinar July 26, 2017 21:56
@filipesilva filipesilva changed the title build(aio): use cli 1.3.0-rc.0 build(aio): use cli 1.3.0-rc Jul 31, 2017
gkalpak
gkalpak approved these changes Jul 31, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as CI is green 👍

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 31, 2017

You can preview 738ef6e at https://pr18290-738ef6e.ngbuilds.io/.

This was referenced Jul 31, 2017
Closed
Closed
@googlebot
Copy link
Copy Markdown

googlebot commented Aug 1, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 1, 2017
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 1, 2017

You can preview fe73080 at https://pr18290-fe73080.ngbuilds.io/.

gkalpak
gkalpak reviewed Aug 1, 2017
View reviewed changes
Comment thread aio/tools/cli-patches/patch.js Outdated
Copy link
Copy Markdown
Member

@gkalpak gkalpak Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is worth keeping this file (and only removing the .patch files), in case @IgorMinar wants to experiment with more optimizations in the future 😃

Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can always add it back when needed.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 1, 2017

You can preview cdfd70b at https://pr18290-cdfd70b.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 1, 2017

You can preview 162a404 at https://pr18290-162a404.ngbuilds.io/.

gkalpak
gkalpak reviewed Aug 1, 2017
View reviewed changes
Comment thread aio/karma.conf.js Outdated
Copy link
Copy Markdown
Member

@gkalpak gkalpak Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Chrome takes forever to "get in touch" with Karma at first 😟
Increasing the no activity timeout, seems to fix it.

@googlebot
Copy link
Copy Markdown

googlebot commented Aug 2, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2017
@gkalpak gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 2, 2017
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Aug 2, 2017

Leaving it to @IgorMinar to give the final LGTM 😃

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 2, 2017

You can preview 9acad91 at https://pr18290-9acad91.ngbuilds.io/.

@gkalpak gkalpak mentioned this pull request Aug 2, 2017
Closed
3 tasks
IgorMinar
IgorMinar approved these changes Aug 2, 2017
View reviewed changes
Comment thread aio/tools/cli-patches/patch.js Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can always add it back when needed.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 2, 2017
@vicb vicb merged commit 9adf40a into angular:master Aug 2, 2017
vicb pushed a commit that referenced this pull request Aug 2, 2017
@filipesilva @vicb
build(aio): use cli 1.3.0-rc (#18290)
116ee33
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@filipesilva
build(aio): use cli 1.3.0-rc (angular#18290)
3b0d12e
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@filipesilva @juleskremer
build(aio): use cli 1.3.0-rc (angular#18290)
fcd432c
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@filipesilva @juleskremer
build(aio): use cli 1.3.0-rc (angular#18290)
7b7c9e0
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@gkalpak gkalpak gkalpak approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@filipesilva @mary-poppins @googlebot @gkalpak @IgorMinar @mhevery @vicb