docs(aio): high-level documentation of AIO tooling by petebacondarwin · Pull Request #18151 · angular/angular

petebacondarwin · 2017-07-15T15:38:51Z

No description provided.

mary-poppins · 2017-07-15T15:53:05Z

You can preview 31f1bed at https://pr18151-31f1bed.ngbuilds.io/.

mary-poppins · 2017-07-15T15:54:35Z

You can preview 1c89bb6 at https://pr18151-1c89bb6.ngbuilds.io/.

mary-poppins · 2017-07-15T16:32:24Z

You can preview 76d40e4 at https://pr18151-76d40e4.ngbuilds.io/.

mary-poppins · 2017-07-15T16:48:50Z

You can preview 9281e95 at https://pr18151-9281e95.ngbuilds.io/.

gkalpak

Docs FTW 💯

gkalpak · 2017-07-18T10:54:32Z

Templates what?

gkalpak · 2017-07-18T11:02:32Z

This section has actually more details than examples/README.md. I think it makes sense to move the exra details (e.g. utility files descriptions) to the README and add instructions/examples on how to actually use them.

gkalpak · 2017-07-18T11:03:47Z

It might be worth mentioning how zips can be built.

gkalpak · 2017-07-18T11:05:33Z

It might be worth adding some info on how to use Plunkers in docs.

Using them in docs should go in the authoring guide. These READMEs are for maintainers so more focussed on the code.

OK then. I thought they were meant for people writing docs (authors, engs writing API docs).

gkalpak · 2017-07-18T11:06:02Z

This section could be moved to the dedicated README.

gkalpak · 2017-07-18T11:07:44Z

plunker-builder/README.md --> transforms/README.md

gkalpak · 2017-07-18T11:09:30Z

stored in the aio/tools/transforms folder. See ... --> stored in this folder.

googlebot · 2017-07-18T14:17:47Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

mary-poppins · 2017-07-18T14:31:52Z

You can preview c9f96fa at https://pr18151-c9f96fa.ngbuilds.io/.

mary-poppins · 2017-07-19T17:10:26Z

You can preview d782637 at https://pr18151-d782637.ngbuilds.io/.

mary-poppins · 2017-07-25T23:07:31Z

You can preview 9fb9a20 at https://pr18151-9fb9a20.ngbuilds.io/.

gkalpak

Personal preference:
Limiting lines 100/120 chars even in markdown files, makes diffing/reviewing easier 😁
_{(Others might disagree.)}

gkalpak · 2017-07-26T11:16:38Z

gkalpak · 2017-07-26T11:18:20Z

kind --> kinds

gkalpak · 2017-07-26T11:19:08Z

scripts tags --> scripts (?)

gkalpak · 2017-07-26T11:20:20Z

system.js --> System.js 😁

gkalpak · 2017-07-26T11:27:06Z

with with --> with

gkalpak · 2017-07-26T12:04:07Z

contains --> contain

gkalpak · 2017-07-26T12:06:06Z

What are -builds versions?

Added a bit more of explanation. If it is still unclear, we can do better.

gkalpak · 2017-07-26T12:06:27Z

script tags --> scripts (?)

gkalpak · 2017-07-26T12:07:04Z

Add a link to the "Plunker tool" docs.

gkalpak · 2017-07-26T12:07:20Z

What about zipper.json?

mary-poppins · 2017-07-31T11:48:53Z

You can preview e72c7bc at https://pr18151-e72c7bc.ngbuilds.io/.

gkalpak · 2017-07-31T15:45:33Z

This will be obsolete after #18290 (but may be worth leaving for future experimentations).

gkalpak · 2017-07-31T15:48:02Z

This file has been renamed.

gkalpak · 2017-07-31T15:55:41Z

gkalpak · 2017-07-31T16:04:09Z

/src/... --> src/... 😁

gkalpak · 2017-07-31T16:06:41Z

Could also mention zipper.json.

gkalpak · 2017-07-31T16:10:18Z

petebacondarwin · 2017-09-21T09:49:11Z

I think we should land this stuff and then iterate. Otherwise it will get stale and no one will want to take it on.

mary-poppins · 2017-09-21T09:59:58Z

You can preview a1e0558 at https://pr18151-a1e0558.ngbuilds.io/.

mary-poppins · 2017-09-21T10:26:15Z

You can preview b4ca7a4 at https://pr18151-b4ca7a4.ngbuilds.io/.

PR Close #18151

angular-automatic-lock-bot · 2019-09-12T17:21:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

petebacondarwin added comp: aio state: WIP labels Jul 15, 2017

googlebot added the cla: yes label Jul 15, 2017

petebacondarwin force-pushed the aio-tooling-docs branch from 1c89bb6 to 31f1bed Compare July 15, 2017 15:40

petebacondarwin force-pushed the aio-tooling-docs branch 2 times, most recently from 76d40e4 to 9281e95 Compare July 15, 2017 16:31

Foxandxss approved these changes Jul 17, 2017

View reviewed changes

gkalpak suggested changes Jul 18, 2017

View reviewed changes

googlebot added cla: no and removed cla: yes labels Jul 18, 2017

mhevery force-pushed the master branch from 08b36cb to 5d4b36f Compare July 20, 2017 21:49

mhevery force-pushed the aio-tooling-docs branch from d782637 to 9fb9a20 Compare July 25, 2017 22:51

gkalpak suggested changes Jul 26, 2017

View reviewed changes

gkalpak reviewed Jul 31, 2017

View reviewed changes

petebacondarwin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed state: WIP labels Sep 21, 2017

petebacondarwin and others added 3 commits September 21, 2017 10:50

docs(aio): high-level documentation of AIO tooling

5bdcec8

docs(aio): high-level documentation of the transforms folder

95985db

docs(aio): add boilerplate readme

ee12c8b

Foxandxss added 3 commits September 21, 2017 10:50

docs(aio): complete the plunker-builder docs

319fb3c

docs(aio): add zipper documentation

dfe0eb0

docs(aio): applying some feedback

a1e0558

petebacondarwin force-pushed the aio-tooling-docs branch from e72c7bc to a1e0558 Compare September 21, 2017 09:50

docs(aio): tidy up tooling documentation

b4ca7a4

gkalpak approved these changes Sep 21, 2017

View reviewed changes

IgorMinar added cla: yes and removed cla: no labels Sep 21, 2017

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): high-level documentation of the transforms folder (#18151)

4530654

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): add boilerplate readme (#18151)

e6c612f

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): complete the plunker-builder docs (#18151)

6f7aa46

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): add zipper documentation (#18151)

ba20e3b

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): applying some feedback (#18151)

48cd503

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): tidy up tooling documentation (#18151)

4c73b52

PR Close #18151

IgorMinar closed this in 28a80e6 Sep 21, 2017

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): high-level documentation of AIO tooling (#18151)

9226760

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): high-level documentation of the transforms folder (#18151)

ed2c8aa

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): add boilerplate readme (#18151)

ba0fb1e

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): complete the plunker-builder docs (#18151)

53a27e0

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): add zipper documentation (#18151)

526a67f

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): applying some feedback (#18151)

5bca58e

PR Close #18151

IgorMinar pushed a commit that referenced this pull request Sep 21, 2017

docs(aio): tidy up tooling documentation (#18151)

04bc525

PR Close #18151

petebacondarwin deleted the aio-tooling-docs branch September 21, 2017 20:42

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019

Conversation

petebacondarwin commented Jul 15, 2017

Uh oh!

mary-poppins commented Jul 15, 2017

Uh oh!

mary-poppins commented Jul 15, 2017

Uh oh!

mary-poppins commented Jul 15, 2017

Uh oh!

mary-poppins commented Jul 15, 2017

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak Jul 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jul 18, 2017

Uh oh!

mary-poppins commented Jul 18, 2017

Uh oh!

mary-poppins commented Jul 19, 2017

Uh oh!

mary-poppins commented Jul 25, 2017

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Jul 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

gkalpak Jul 18, 2017 •

edited

Loading