feat(compiler): open the serializer API for i18n#14281
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
feat(compiler): open the serializer API for i18n#14281marclaval wants to merge 1 commit intoangular:masterfrom
marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
marclaval
force-pushed
the
i18nCustomSerializer
branch
2 times, most recently
from
dd5a823 to
f74e9c9
Compare
marclaval
added
area: i18n
Contributor
|
I'm generally 👍 on this but I think it should be delayed as much as possible until there is a concrete use case because once the API is public we can not change it any more. Do you have such a use case ? Also #14290 update the API to also return the bundle locale. |
Contributor
|
Needs rebase |
marclaval
force-pushed
the
i18nCustomSerializer
branch
from
f74e9c9 to
f560e26
Compare
Contributor
|
Closing for now as there is no urge to open this API |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR opens the serializer API of i18n, in order to allow developers to do something like this:
The serializer is loaded with a
require(), so the path can be relative, absolute or a dependency.