chore(ci): validate the message of each new commit during ci#13815
Closed
matsko wants to merge 1 commit intoangular:masterfrom
Closed
chore(ci): validate the message of each new commit during ci#13815matsko wants to merge 1 commit intoangular:masterfrom
matsko wants to merge 1 commit intoangular:masterfrom
Conversation
This patch adds the gulp command of `tools:validate-commit-message` which will validate the range of commits messages present in the active branch.
matsko
force-pushed
the
gulp_lint_commit_message
branch
from
3df4a8e to
dae8f49
Compare
vicb
reviewed
Jan 6, 2017
| }); | ||
|
|
||
| gulp.task('tools:validate-commit-message', () => { | ||
| exec('git log --reverse --oneline HEAD ^upstream/master', (error, stdout, stderr) => { |
Contributor
There was a problem hiding this comment.
I don't use upstream :(
Could we use the full name here instead of an alias so that everybody is happy ?
vicb
reviewed
Jan 6, 2017
| "refactor", | ||
| "revert", | ||
| "style", | ||
| "test" |
Contributor
|
What about using #9953 ? |
IgorMinar
added a commit
to IgorMinar/angular
that referenced
this pull request
Jan 20, 2017
This patch adds the gulp command of `validate-commit-messages` which will validate the range of commits messages present in the active branch. This check now runs on CI as part of the linting checks. Allowed commit message types and scopes are controlled via commit-message.json file and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted by @matsko in angular#13815. Ideally we should switch over to something like https://www.npmjs.com/package/commitplease as suggested in angular#9953 but that package currently doesn't support strict scope checking, which is one of the primarily goal of this PR. Note that this PR removes support for "chore" which was previously overused by everyone on the team. Closes angular#13815 Fixes angular#3337
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
This patch adds the gulp command of `validate-commit-messages` which will validate the range of commits messages present in the active branch. This check now runs on CI as part of the linting checks. Allowed commit message types and scopes are controlled via commit-message.json file and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted by @matsko in angular#13815. Ideally we should switch over to something like https://www.npmjs.com/package/commitplease as suggested in angular#9953 but that package currently doesn't support strict scope checking, which is one of the primarily goal of this PR. Note that this PR removes support for "chore" which was previously overused by everyone on the team. Closes angular#13815 Fixes angular#3337
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
idlechara
pushed a commit
to idlechara/angular
that referenced
this pull request
Apr 27, 2021
This patch adds the gulp command of `validate-commit-messages` which will validate the range of commits messages present in the active branch. This check now runs on CI as part of the linting checks. Allowed commit message types and scopes are controlled via commit-message.json file and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted by @matsko in angular#13815. Ideally we should switch over to something like https://www.npmjs.com/package/commitplease as suggested in angular#9953 but that package currently doesn't support strict scope checking, which is one of the primarily goal of this PR. Note that this PR removes support for "chore" which was previously overused by everyone on the team. Closes angular#13815 Fixes angular#3337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.