Support TypeScript plugin extensibility model for Language Service features #13716

RyanCavanaugh · 2016-12-30T00:35:56Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features) (n/a)
Docs have been added / updated (for bug fixes / features) (n/a)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
No language service for the new TypeScript plugin model exists

What is the new behavior?
A language service for the new TypeScript plugin model exists

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Other information:

Commits in this PR:

Add some null checking: Additional diagnostics
Avoid crashing in certain situations: Null checks were missing in a few places
Port ts2.1 compat fixes from Chuck: Patches from @chuckjaz to make things cross-compatible with TS2.0 and TS2.1
Support new plugin model from TypeScript: New proxy LS plugin model
'create' method from LS module: Expose the plugin factory function from the language-service module

When the corresponding PR microsoft/TypeScript#12231 goes in, the following workflow will be enabled:

Clone angular/quickstart
Add "plugins": [{ "name": "@angular/language-service" }, }] to tsconfig.json
npm install --save-dev @angular/language-service
🎉 Completions, go-to-def, diagnostics, and hover info appear in VS Code and other tsserver-based plugins

chuckjaz

Please squash changes into one or two changes that describe the change and make logical sense.

Please change the commit messages to conform to https://github.com/angular/angular/blob/master/CONTRIBUTING.md (e.g. refactor(compiler): check invalid parameters, feat(language-service): support TypeScript 2.2 plugin model.)

Please fix the tslint error reported in CI.

Consider converting the tests in ts-plugin.spec.ts to using the new plugin.
Consider removing the old plugin.

chuckjaz · 2017-01-03T18:22:56Z

modules/@angular/language-service/src/language_service.ts

Why throw here? Is this left-over debugging code?

RyanCavanaugh · 2017-01-07T07:29:55Z

@chuckjaz thanks for review - pushed up a fresh commit

chuckjaz

Overall looks good. However we are particular about the commit message slugs because we use an automated process to add the into the change log.

Please change your commit message to "feat(language-service): support TS2.2 plugin model" (note the lower case in "support").

RyanCavanaugh · 2017-01-07T23:04:33Z

Done

matsko · 2017-01-09T23:11:53Z

Landed as 99aa49a

cyrilletuzi · 2017-01-21T11:58:18Z

Do we agree it's landed in 4.0.0-beta.3 but still not usable, as we're waiting for microsoft/TypeScript#12231, even with last typescript@next ? Or is there a way to already test that (seems strange that the PR has been merged without testing) ?

chuckjaz · 2017-01-21T21:15:26Z

I agree it is a bit strange but one of them had to be first. This code replaces previous plug-in specific code that was based on a previous TypeScript plug-in proposal.

The TypeScript plug-in has unit tests and the @angular/language-service is, itself, is usable in as part of a vscode plugin (https://github.com/angular/vscode-ng-language-service/).

cyrilletuzi · 2017-01-21T21:31:10Z

Thanks (it wasn't to criticize, just to check I didn't miss something, because it's a long awaited feature that will help people a lot in my courses)

cyrilletuzi · 2017-02-15T18:20:42Z

microsoft/TypeScript#12231 has been merged ! Does this mean we can finally use @angular/language-service directly from tsconfig.json ?

chuckjaz · 2017-02-15T18:55:46Z

This should work in nightly but I haven't added CI tests yet to verify that it continues to work with out latest builds.

cyrilletuzi · 2017-02-16T21:19:55Z

For info, I tried with yesterday and today nightly, and last stable version of @angular/language-service (2.4.7). Can't get it work, but no errors from tsserver.

RyanCavanaugh · 2017-02-17T08:58:22Z

I've got some sample / documentation repos up you can try.

https://github.com/RyanCavanaugh/angular2-seed
https://github.com/RyanCavanaugh/sample-ts-plugin

(Note: about to head out on vacation for 2 weeks with no internet access, so... hopefully you can get them to work!)

cyrilletuzi · 2017-02-17T12:52:40Z

@RyanCavanaugh is there anything specific except "plugins": [ { "name": "@angular/language-service"} ] in tsconfig.json ? Because I have the exact same config and versions, and I don't get any completion in VS Code.

RyanCavanaugh · 2017-02-17T16:21:47Z

@cyrilletuzi you'll also need the VS Code workspace settings to enable loading the local version of the language service

cyrilletuzi · 2017-02-19T10:41:29Z

Problem was the version of @angular/language-service. Works with 4.0.0-beta.3 (as in angular-seed) and last beta 4.0.0-beta.8. But not with 4.0.0-beta.7 and not with 2.4.x.

angular-automatic-lock-bot · 2019-09-10T21:21:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Dec 30, 2016

RyanCavanaugh changed the title ~~Ls fixes~~ Support TypeScript plugin extensibility model for Language Service features Dec 30, 2016

This was referenced Dec 30, 2016

Feat: Support TypeScript 2.1 #13715

Closed

Language service proxy microsoft/TypeScript#12231

Merged

chuckjaz reviewed Jan 3, 2017

View reviewed changes

jamespacileo mentioned this pull request Jan 4, 2017

ionic build does not work with typescript@next (>= 2.1) ionic-team/ionic-app-scripts#197

Closed

chuckjaz suggested changes Jan 7, 2017

View reviewed changes

feat(language-service): support TS2.2 plugin model

31e8a06

chuckjaz approved these changes Jan 9, 2017

View reviewed changes

chuckjaz added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Jan 9, 2017

matsko closed this Jan 9, 2017

HerringtonDarkholme referenced this pull request in mhartington/nvim-typescript Apr 11, 2017

feat(): use local tsserver first

87362a8

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Support TypeScript plugin extensibility model for Language Service features #13716

Support TypeScript plugin extensibility model for Language Service features #13716

Uh oh!

Conversation

RyanCavanaugh commented Dec 30, 2016

Uh oh!

chuckjaz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuckjaz Jan 3, 2017

Choose a reason for hiding this comment

Uh oh!

RyanCavanaugh Jan 7, 2017

Choose a reason for hiding this comment

Uh oh!

RyanCavanaugh commented Jan 7, 2017

Uh oh!

chuckjaz left a comment

Choose a reason for hiding this comment

Uh oh!

RyanCavanaugh commented Jan 7, 2017

Uh oh!

matsko commented Jan 9, 2017

Uh oh!

cyrilletuzi commented Jan 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chuckjaz commented Jan 21, 2017

Uh oh!

cyrilletuzi commented Jan 21, 2017

Uh oh!

cyrilletuzi commented Feb 15, 2017

Uh oh!

chuckjaz commented Feb 15, 2017

Uh oh!

cyrilletuzi commented Feb 16, 2017

Uh oh!

RyanCavanaugh commented Feb 17, 2017

Uh oh!

cyrilletuzi commented Feb 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RyanCavanaugh commented Feb 17, 2017

Uh oh!

cyrilletuzi commented Feb 19, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chuckjaz left a comment •

edited

Loading

cyrilletuzi commented Jan 21, 2017 •

edited

Loading

cyrilletuzi commented Feb 17, 2017 •

edited

Loading