feat(NgComponentOutlet): add NgComponentOutlet directive #13383

mhevery · 2016-12-11T22:05:00Z

feat(NgComponentOutlet): add NgComponentOutlet directive

Add NgComponentOutlet directive that can be used to dynamically create
host views from a supplied component.

Closes #11168
Takes over PR #11235

googlebot · 2016-12-11T22:05:01Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

shlomiassaf · 2016-12-11T22:29:50Z

@mhevery I have pushed the updated code to my branch.

Tests are passing.

It includes a rebase + all the requested changed except the namings.
(support for * syntax)

I didn't have time to edit my WIP comminets so commits should be squashed :)

There are some lines of codes commented out in the tests since Output is not supported in * syntax.

I think you should use it as a baseline

https://github.com/shlomiassaf/angular/tree/ng-component-outlet

mhevery · 2016-12-14T17:21:14Z

@shlomiassaf thanks, i am also making sure that ngTemplateOutlet and ngComponentOutlet are consistent and adding documentation. At this point I think the two have diverged too much to be able to reuse your branch. Sorry.

mhevery · 2016-12-14T23:01:56Z

@vicb ready for review.

MaximCrabbe · 2016-12-30T13:47:58Z

So how long does it take on average for a PR like this to be reviewed? (Just would like to know, not 'pushing'). This NgComponentOutlet seems usefull!

shlomiassaf · 2016-12-31T00:44:03Z

Holiday season I guess (:

…

Sent from my iPhone

On Dec 30, 2016, at 3:48 PM, Maxim Crabbé ***@***.***> wrote: So how long does it take on average for a PR like this to be reviewed? (Just would like to know, not 'pushing'). This NgComponentOutlet seems usefull! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vicb · 2017-01-04T19:38:56Z

modules/@angular/common/src/directives/ng_template_outlet.ts

What about @Input('ngTemplateOutletContext') public context: Object;

IMO it is better as-is

vicb · 2017-01-04T19:39:22Z

modules/@angular/common/src/directives/ng_template_outlet.ts

What about @Input('ngTemplateOutlet') public template: TemplateRef<any>;

IMO it is better as-is

vicb · 2017-01-04T19:47:00Z

LGTM, please rebase and consider the minor comments.

mhevery · 2017-01-04T21:33:49Z

Rebased

pkozlowski-opensource · 2017-01-05T10:08:19Z

modules/@angular/common/src/directives/ng_component_outlet.ts

Could we change it so only views we've created are destroyed here? In theory we could have multiple directives sitting on the same <template> element, they could be creating their own views and this logic would mess up views created by other directives, no?

This is what is done in the template outlet:

angular/modules/@angular/common/src/directives/ng_template_outlet.ts

Lines 48 to 50 in 35f9a1c

if (this._viewRef) {

this._viewContainerRef.remove(this._viewContainerRef.indexOf(this._viewRef));

}

good point. Fixed

BREAKING CHANGE: - Deprecate `ngOutletContext`. Use `ngTemplateOutletContext` instead

Add NgComponentOutlet directive that can be used to dynamically create host views from a supplied component. Closes angular#11168 Takes over PR angular#11235

lgleim · 2017-01-08T10:53:11Z

modules/@angular/examples/common/ngComponentOutlet/ts/module.ts

+// #docregion CompleteExample
+@Injectable()
+class Greeter {
+  suffix = '!'


[32, 15]: Missing semicolon.

lgleim · 2017-01-08T10:54:36Z

modules/@angular/common/src/directives/ng_component_outlet.ts

+ * Instantiates a single {@link Component} type and inserts its Host View into current View.
+ * `NgComponentOutlet` provides a declarative approach for dynamic component creation.
+ *
+ * `NgComponentOutlet` requires a component type, if a falsy value is set the view will clear and


Should probably be if a false value instead of if a falsy value.

matsko · 2017-01-09T19:39:59Z

@mhevery please fix CI issues.

matsko · 2017-01-09T23:08:02Z

Landed as 8578682

MaximCrabbe · 2017-01-12T21:22:00Z

Sorry I am not so familiar with how big open source projects work. Is this feature now implemented? (I think so in 8578682 commit) however what version of angular do I need, I guess it will be 2.5 or something ?

DzmitryShylovich · 2017-01-12T21:29:21Z

beta 4 https://github.com/angular/angular/blob/master/CHANGELOG.md#400-beta3-2017-01-11

angular-automatic-lock-bot · 2019-09-11T17:22:22Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Dec 11, 2016

mhevery mentioned this pull request Dec 11, 2016

feat(NgComponentOutlet): add NgComponentOutlet directive #11235

Closed

3 tasks

pkozlowski-opensource added the area: common Issues related to APIs in the @angular/common package label Dec 12, 2016

mattlewis92 mentioned this pull request Dec 12, 2016

Provide a way of overriding each components templates mattlewis92/angular-calendar#16

Closed

7 tasks

mhevery force-pushed the pr-11235 branch 3 times, most recently from 7b04d63 to 6406369 Compare December 14, 2016 22:54

mhevery requested review from IgorMinar and vicb December 14, 2016 23:00

mhevery force-pushed the pr-11235 branch from 6406369 to 6c5e339 Compare December 14, 2016 23:01

chuckjaz mentioned this pull request Dec 15, 2016

attaching dynamic templates to a component #13495

Closed

vicb reviewed Jan 4, 2017

View reviewed changes

vicb added area: core Issues related to the framework runtime action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM labels Jan 4, 2017

mhevery force-pushed the pr-11235 branch from 6c5e339 to dfcaadc Compare January 4, 2017 21:33

mhevery added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 4, 2017

pkozlowski-opensource reviewed Jan 5, 2017

View reviewed changes

mhevery added 2 commits January 6, 2017 09:36

fix: correctly show error when karma fails to load

2eb89b8

feat(NgTemplateOutlet): Make NgTemplateOutlet compatible with * syntax

8c0b9a5

BREAKING CHANGE: - Deprecate `ngOutletContext`. Use `ngTemplateOutletContext` instead

mhevery force-pushed the pr-11235 branch from dfcaadc to 369a53d Compare January 6, 2017 17:37

mhevery added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jan 6, 2017

feat(NgComponentOutlet): add NgComponentOutlet directive

b8b02d6

Add NgComponentOutlet directive that can be used to dynamically create host views from a supplied component. Closes angular#11168 Takes over PR angular#11235

mhevery force-pushed the pr-11235 branch from 694dfe8 to b8b02d6 Compare January 7, 2017 00:28

shlomiassaf mentioned this pull request Jan 7, 2017

MdDialog communication (i.e: passing data to MdDialog) angular/components#2181

Closed

lgleim suggested changes Jan 8, 2017

View reviewed changes

matsko closed this Jan 9, 2017

mhevery deleted the pr-11235 branch June 2, 2017 17:07

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

	if (this._viewRef) {
	this._viewContainerRef.remove(this._viewContainerRef.indexOf(this._viewRef));
	}

feat(NgComponentOutlet): add NgComponentOutlet directive #13383

feat(NgComponentOutlet): add NgComponentOutlet directive #13383

Uh oh!

Conversation

mhevery commented Dec 11, 2016

Uh oh!

googlebot commented Dec 11, 2016

Uh oh!

shlomiassaf commented Dec 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhevery commented Dec 14, 2016

Uh oh!

mhevery commented Dec 14, 2016

Uh oh!

MaximCrabbe commented Dec 30, 2016

Uh oh!

shlomiassaf commented Dec 31, 2016 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vicb commented Jan 4, 2017

Uh oh!

mhevery commented Jan 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matsko commented Jan 9, 2017

Uh oh!

matsko commented Jan 9, 2017

Uh oh!

MaximCrabbe commented Jan 12, 2017

Uh oh!

DzmitryShylovich commented Jan 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

shlomiassaf commented Dec 11, 2016 •

edited

Loading

DzmitryShylovich commented Jan 12, 2017 •

edited

Loading