fix(core): Ensure effects can be created when Zone is not defined (#49890)

atscott · thePunderWoman · commit fd9dcd36cdf9 · 2023-04-17T17:34:58.000Z
Effects should run in the same zone they were created in. However, if ZoneJS is not used at all, effects should just run (without zone). This is similar to what's done in the elements `ComponentNgElementStrategy`. fixes #49798 PR Close #49890
diff --git a/packages/core/src/render3/reactivity/effect.ts b/packages/core/src/render3/reactivity/effect.ts
@@ -32,12 +32,12 @@ export type EffectCleanupRegisterFn = (cleanupFn: EffectCleanupFn) => void;
  */
 export class EffectManager {
   private all = new Set<Watch>();
-  private queue = new Map<Watch, Zone>();
+  private queue = new Map<Watch, Zone|null>();
 
   create(
       effectFn: (onCleanup: (cleanupFn: EffectCleanupFn) => void) => void,
       destroyRef: DestroyRef|null, allowSignalWrites: boolean): EffectRef {
-    const zone = Zone.current;
+    const zone = (typeof Zone === 'undefined') ? null : Zone.current;
     const watch = new Watch(effectFn, (watch) => {
       if (!this.all.has(watch)) {
         return;
@@ -74,7 +74,11 @@ export class EffectManager {
 
     for (const [watch, zone] of this.queue) {
       this.queue.delete(watch);
-      zone.run(() => watch.run());
+      if (zone) {
+        zone.run(() => watch.run());
+      } else {
+        watch.run();
+      }
     }
   }
 
